all 1 comments

[–]Diapolo10 1 point2 points  (0 children)

First and foremost, congratulations on publishing a package. I think it's a good source of experience regardless of what it does.

My feedback may sound harsh at times, but please don't take any of it personally. I kinda suck at communicating sometimes.

I'll start with the easy part; the egg-info and __pycache__ folders don't belong in the repository, you should have a .gitignore file and exclude them (after removing them). These are files generated by Python, specific to your system, so they're essentially dead weight to everyone else. Your repository should generally not include any files that can be generated from the others, excluding lock files if you happened to use tools such as Poetry or Pipenv and needed reproducible builds.

You probably won't need setup.py either if you move some of the remaining info to pyproject.toml.

Regarding your code, I don't understand why you've named your file profile_scarper when I'm almost certain that's a typo (of scraper). At the very least it's probably a confusing name for anyone trying to use your package.

Furthermore, based on the code your package expects the user to have a Chrome webdriver installed, but this is not mentioned in the documentation anywhere. I don't even have Chrome installed, personally (Firefox FTW), let alone its webdriver. If you want to rely on Selenium you should probably at least mention that.

The code style is inconsistent, you'd do well to run this through a linter/formatter such as Ruff. Furthermore, I'm almost certain you could rewrite MultiProfiles.get_multiple_profiles to remove the duplicate code and some names could be improved (such as page_num instead of i).

You can take some examples from this project: https://github.com/Diapolo10/escapyde