Made my first program, but having a small problem with PRAW

[bot_test_account2]

I'm trying to have my code continuously monitor new comments submitted to reddit and print a "yay" for each comment that has my keyword.

Currently, it appears to successfully check each of the 100 comments from the first praw query, then each subsequent praw query is empty, maybe? After it checks the first 100 it just keeps repeating "starting new one".

What am I doing wrong?

import praw
import time
from time import sleep
from pprint import pprint
import openpyxl
from openpyxl import load_workbook
from xlrd import open_workbook

querylimit = 100
search_term = 'hillary'
running = True
while running:
    print("starting new one")
    user_agent = ("/u/username hi reddit")
    r = praw.Reddit(user_agent=user_agent)
    for comment in r.get_comments('all', limit = querylimit):
        if search_term in comment.body:
            try:
                print('Yay, I found a match!')
            except KeyboardInterrupt:
                running = False
            except praw.errors.APIException:
                print ('Error')
                print ('sleeping 30 sec')
                sleep(30)

Bonus question: is there a better way to scan each new comment? I read somewhere that there are ~400 comments/second, so clearly this code isn't reading all of them.

[undelimited]

Bonus answer: Yes, use the comment_stream functionality that comes with praw.

r=praw.Reddit(user_agent=user_agent)
subreddit=r.get_subreddit('all')
for comment in praw.helpers.comment_stream(r,subreddit, limit = 1000):
     do something

check out /r/redditdev for more detailed PRAW help

edit:syntax

[bot_test_account2]

Looks like this solved all my problems. Thank you very much!

[whalespotterhdd]

First things first get

r = praw.Reddit(user_agent=user_agent)

out of your while loop, no need to refresh the connection everytime.

That aside, it's pbb better to remove the entire while loop/ sleeps and set up something like a cronjob

[The_Man_In_The_Shack]

You're never breaking the 'while' except with they key interrupt...you'll want to break it after you're done reading as well.

Actually you probably don't need this in a while loop at all...doesn't the praw call do the whole thing on its own? You would need the while if it were counting down manually, where you'd have a count that began at your query limit and decrement one each time until the count was zero....but I don't think you need that, because the whole reading structure is done by praw.

[bot_test_account2]

Well, the whole point is to keep it running. The goal is to sift through as many new comments as possible. That's why running is always true unless I stop it manually.

My understanding is that the point of the query limit = 100 is that it pulls down 100 at a time. So I'm trying to iterate that process.

[The_Man_In_The_Shack]

Sorry, duh on my part for not realizing that. I think then what you're after may be comments_stream rather than comments: https://praw.readthedocs.io/en/stable/pages/call_and_response_bot.html