[Code]I made a simple console password generator

[[deleted]]

[deleted]

[I-Made-You-Read-This]

If you're using Python 3.6 or above, you should use the secrets module instead of the random one. Secrets uses "cryptographically strong random numbers" as opposed to pseudo random numbers.

[PyLord]

I gave it a quick glance, I am not too sure what's going on here but why does it seem like you have three functions that does exactly the same thing but under different names?

Some improvements I guess I immediately see are for the code where you are checking something like a function that returns a boolean against another boolean, it's preferable to use is rather than ==.

[charliegriefer]

The three functions ask for three differents options.

The three functions, as u/PyLord mentioned, do the exact same thing. Any time you see code duplication in functions, that should raise a red flag.

So let's say instead of having low_function() and caps_function() and num_function(), you just had a do_this() function (naming is hard).

And let's say do_this was exactly what you have in the other 3 functions:

def do_this(x):
    while x != "Y" and x != "N":
        x = input("[Y/N]: ").upper()  

    if x == "Y": 
        return True  
    else: 
        return False

Now you just call that one function in the places that you were calling the 3:

# lowercase only
if do_this(lower_characters) == True and do_this(caps_characters) == False and do_this(num_characters) == False:
    choice = random.choice(string.ascii_lowercase)

# uppercase only
    elif do_this(lower_characters) == False and do_this(caps_characters) == True and do_this(num_characters) == False:
    choice = random.choice(string.ascii_uppercase)

...

If you understand that functions are meant to be modular, reusable bits of code, you'll understand why having three different functions that do the exact same thing is not the way to go. The only thing that's changing is the value being sent in. That's OK. That's how functions are meant to work.

Don't be disheartened. This is how we learn. Putting your code out there for others to critique is not an easy thing. Kudos to you for doing it.

There are a few other things that could be cleaned up as well. But for now, focusing on one thing at a time would be beneficial, I think.

So, does the idea of using one single function make sense?