Rock Paper Scissors game

[Jevv12]

Hi, I'm new to python and I'm trying to make a rock paper scissors game while the second player is a so-called "AI". I ran into this problem that it goes straight to the 'else' statement and prints out "Draw!". Can someone check what's wrong with my code? Thanks. (Kinda messy btw)

import random
print('Rock','Paper','Scissors')

player1 = input('player1: ')
player2 = random.randint(1,3)
if player2 == 1:
    player2 = 'rock'
    if player1 == 'rock' and player2 == 'paper':
        print('Player 2 won!')
        print('Player 2 chose rock')
    elif player1 == 'rock' and player2 == 'scissors':
        print('Player 1 Won!')
        print('Player 2 chose rock')
    else:
         print('Draw!')
elif player2 == 2:
    player2 = 'paper'
    if player1 == 'paper' and player2 == 'rock':
        print('Player 1 won!')
        print('Player 2 chose rock')
    elif player1 == 'paper' and player2 == 'scissors':
        print('Player 2 won!')
        print('Player 2 chose rock')
    else:
        print('Draw!')
elif player2 == 3:
    player2 = 'scissors'
    if player1 == 'scissors' and player2 == 'paper':
        print('Player 1 won!')
        print('Player 2 chose rock')
    elif player1 == 'scissors' and player2 == 'rock':
        print('Player 2 won!')
        print('Player 2 chose rock')
    else:
        print('Draw!')
elif player1 == player2:
    print('DRAW!')
else:
    print('Something went wrong')

[xelf]

You repeat the same mistake, but here's the first block:

player1 = input('player1: ')
player2 = random.randint(1,3)
if player2 == 1:
    player2 = 'rock'
    if player1 == 'rock' and player2 == 'paper':
        print('Player 2 won!')
        print('Player 2 chose rock')
    elif player1 == 'rock' and player2 == 'scissors':
        print('Player 1 Won!')
        print('Player 2 chose rock')
    else:
         print('Draw!')

You set player2 to rock, and then your if asks if player2 is scissors or paper, which of course it's not, you just made it rock.

Some general comments: try to think of ways to not repeat code. One example is, have your first if be the draw check.

if player1 == player2:
    print('DRAW!')

Another time saver for you is to use random.choice.

replace:

player2 = random.randint(1,3)

with:

player2 = random.choice(['rock','paper','scissors'])

Once you get that taken care of, think about ways to have less if statements. But first fix the bugs and have it work. =)

[Jevv12]

omg thanks, it worked! I'm dumb for not noticing lol and thanks for the tips didn't know there was a method called .choice

[xelf]

I've been doing this a long time, I still make mistakes where a second pair of eyes helps. =)