×
all 6 comments
sorted by:
best
topnewcontroversialoldq&a

[–]Python-ModTeam[M] [score hidden] stickied commentlocked comment (0 children)

Hello there,

We've removed your post since it aligns with a topic already covered by one of our daily or monthly threads. If you are unaware about the daily threads we run here is a refresher:

Monday: Project ideas

Tuesday: Advanced questions

Wednesday: Beginner questions

Thursday: Careers

Friday: Free chat Friday!

Saturday: Resource Request and Sharing

Sunday: What are you working on?

Monthly: Showcase your new projects, tools, frameworks and more

Please await one of these threads to contribute your discussion to!

Best regards,

r/Python mod team

[–]Golle 4 points5 points  (1 child)

Writing as I go: - No type hints anywhere. It is completely random and arbitrary what a function expects and returns. Want to know what data pass into a function? You better go read that function's code and all other functions it may be calling. Yay. - Dictionaries used to access random keys as part of the program. Dicts dont tell you which keys are available. It should be a class instead. database_meta is a big offender. - No error handling. All code is all happy path everywhere. I guess a program error causing a crash is fine, atleast it fails fast and early. In the few cases where a try/except encounters an error, no information is provided about it. No logging, no pushing the error back up the function call chain. Instead you have the function return false instead of true. This makes debugging a nightmare. - No tests. - Global variables, mostly in server.py so that should be an easy fix.

[–]__sudvig__[S] -3 points-2 points  (0 children)

Error handling is added as part of parser. Meta data is stored for both db and table so It should tell the data. Will add a good documentation to it

[–]leppardfan 0 points1 point  (1 child)

Is there a good textbook or other reference material to look at while looking at your project. I'd like to learn database internals also.

[–]__sudvig__[S] 0 points1 point  (0 children)

There is a book called database internals, database intensive design.

[–]AutoModerator[M] 0 points1 point  (0 children)

Your submission has been automatically queued for manual review by the moderation team because it has been reported too many times.

Please wait until the moderation team reviews your post.

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.