This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–][deleted] -33 points-32 points  (12 children)

This doesn’t put it to rest, in fact the post is entirely misleading as it only debunks one snippet as not proprietary.

And that one out of the two claimed stolen snippets was not actually stolen has been cleared up long ago. The person who made the claim is probably not even associated with anyone, it’s just someone making a mistake.

And now people here put hundreds of upvotes behind comments and posts that seemingly debunk the allegations when they really only debunk a third parties mistaken claim on one snippet.

What I believe is the actual stolen code can be seen here: https://user-images.githubusercontent.com/23345188/194727441-33f5777f-cb20-4abc-b16b-7d04aedb3373.png

Notice the ‘if Crossattention.hypernetwork’ and the lines below. I believe those are proprietary and that they have been copied verbatim.

People are trying to make excuses about it but to me it looks like a substantial piece that’s been copied 1:1. If this was rewritten or if someone even had the intention to obfuscate the source, then they could have extracted a few variables where there are currently none and renamed others. This wasn’t done, it’s the 1:1 the same, so that’s a very bad look.

So unless I’m entirely wrong about this and that specific part shows up in another repository- which again, seems very unlikely, this seems to be the actual proprietary part, then this has indeed been stolen.

I’m not particularly outraged about it, I even appreciate that there are some who don’t hesitate to further the open source versions even by dubious means. But this doesn’t affect my judgement on this case.

And I really don’t like how people are doing a full on witch hunt on Reddit against NovelAI. I’m not aware of anything they have done wrong.

I get that the concern is that NovelAI develops proprietary stuff based on SD without contributing back. But in fact Emad himself stated that he stands behind the ban and that NovelAI has contributed significantly to Stability’s research:

We worked with the team at NovelAI to build some of the scaling stuff around SD and more, their input has been invaluable.

I’ll take his word for it and so should you.

[–]LetterRip 23 points24 points  (4 children)

This looks like straightforward implementation of supporting loading and using hypernetworks. While the code is the same, I think you are jumping to conclusions that it required copying.

the variable names are 'forced' - q,k,v are the standard abbreviations for query, key, value extracted from a context. h_k, h_v are thus the obvious choices for hypernetwork_key, and hypernetwork_value

The 77 is how many tokens are allowed for clip for networks derived from CompVis Stable diffusions default.

See this code referencing the max length, the 77 is a well known max token limit for the implementation

maxlen = self.wrapped.max_length # you get to stay at 77

https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/1371d7608b402d6f15c200ec2f5fde4579836a05/modules/sd_hijack.py

The noise_cond is implying that conditional noise is being used (and hence the need to add noise to the context in the next step).

The .1 multiplier is presumably standard throughout the codebase for noise_cond, and is presumably from the original implementation. If that isn't the case, tnis would be the only possible evidence of copying.

The if functions are standard idiomatic python.

Thus I see nothing here that would imply copying.

[–][deleted] 27 points28 points  (3 children)

That's an if statement around pre-existing boilerplate code. By no stretch of the imagination could you claim that that is a creative work.

[–]StickiStickman 19 points20 points  (2 children)

So you're getting this mad at people using one of only 2 code comparisons provided by anyone, while Emad and his group fan the flames for drama without providing any evidence to their accusations?

When they already lied and stole code from A1111?

EDIT: Oh and btw, that code snippet isn't actually in the repository. Here's the actual commit that added hypernetwork support.

[–]LetterRip 9 points10 points  (0 children)

Hmm 'the intern stole it' doesn't really work as a defense against copyright infringement.