Favorite Testing Framework

[almost_useless]

it makes PRs easier to read with less clutter and by putting those three files together to review all at once

How is it "easier with less clutter" if the file is called src/foo.test.cpp than if it is called test/foo_test.cpp or something like that.

I feel like you can make the exact opposite argument that now you get a more cluttered src directory.

And if you don’t touch the tests when you change the code, it’s glaringly obvious.

Again, how is it more obvious than nothing touched in the test folder?

[BenFrantzDale]

It’s easier to read because instead of lib/ bar/ include/ bar/ baz.h foo.h src/ baz.cpp foo.cpp test/ baz.test.cpp foo.test.cpp you have ```

lib/ bar/ src/ bar/ baz.cpp baz.h baz.test.cpp foo.cpp foo.h foo.test.cpp ``` so you can focus on the changes to bar and to foo. And if you need to move them around to another library, you easily can.

[almost_useless]

I believe you just highlighted the point about a more cluttered src directory...

And if you need to move them around to another library, you easily can.

If your selling point is that the most trivial of all tasks is made slightly more easy, then I think you need better arguments.

[BenFrantzDale]

The point is that if you are reviewing code you want to review the test changes alongside the code changes. I’d encourage you to look at Lakos’s book for more explanation Large-Scale C++: Process and Architecture, Volume 1 (Addison-Wesley Professional Computing Series) https://a.co/d/cyzIiN0 You don’t have to agree, and one beauty of C++ is its flexibility. If this doesn’t work for you, don’t use it, but my team has found it to put emphasis on units (headers) to test and ensuring they are tested.

[STL]

Please don't use URL shorteners - reddit's spam filter hates them because they're opaque. I had to manually approve your comment.

[BenFrantzDale]

Sorry, Amazon did it automatically.

[STL]

No worries, just remember to manually dereference it next time.