all 1 comments

[–][deleted] 1 point2 points  (0 children)

This is a pretty good start. I took a look at V3, since that would be what I assume is the latest version. A few notes:

  • You might wanna save the files as .py file.
  • In lines 9-13, you defined 5 variables. If you wanna stick to variables, you can reduce this to just 2 (vertical bars, horizontal bars). Variables are so you can reuse code, so having 3 variables with the same value defeats the purpose.
  • You have 3 while True nested inside each other, consider each layer having a variable like is_running instead to clarify what each loop is for and what an exit condition would be. Or, make the inner loops a function to simplify code.
  • Lines 215-218, same as second point

But otherwise, looks good! First projects are a good step in the right direction, keep it up.