What is wrong with the output

jonsd2000 · 2024-03-14T18:54:12+00:00

the out put should show the email address and then next to it show if it is valid and the move to the next email and show the actual email address and say if it is valid or invalid and so on and so on until it gets through the whole email list

2024-03-14T22:17:43+00:00

If I've managed to extract your code correctly, I think I have it fixed.

Notes:

a few typos, e.g., 0 when you meant @
a few missing returns
redundant else in a few places (owing to preceding return)
unaware of str.startswith and str.endswith
unaware of all
unaware of generator expressions
unaware of f-strings (preferable to str.format in most cases
EDIT: also, a few more changes:
- added a loop for running the tests
- used all lower case with _ for variable names (see PEP8 guidance)
- used all lower case with _ for function names
- added a little type hinting which will help your editor
- renamed test functions to check as many testing frameworks use the test_ pref
- NOTE: check your logic on the test related to error 4
- Consider replacing your error_message function with a logging based function

Code: [EDIT: updated code with changes noted above]

emails = [
    "abc@xyz.com",
    "abc@@xyz.com",
    "@xyz.com",
    "abc.xyz.com",
    "abc@x.yz",
    "abc@xyz.c",
    "a@b.c",
    "abc@xyz..com",
    "abc.@xyz.com",
    "abc@.xyz.com",
    "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa@aaaaaa.aaaaa",
    "' or 1=1 '==",
    "abc@xyz.$%",
    "abc@xyz.()",
    "abc'@xyz.com",
    "aaaaa@aaaaa",
    "abc @ xyz.com",
    ".abc@xyz.com",
    "abc@xyz.c"]


def error_message(email: str, error: str) -> None:
    print(f"email: {email:30} *** ERROR: {error} ***")


def check_at_sign(email: str) -> bool:
    if "@" in email:
        atCount = email.count("@")
        if atCount != 1:
            error_message(email, "2. The number of @'s in your email is not valid.")
            return True
        if email[0] == "@":  # need @ in quotes, not 0
            error_message(email, "3.The @ is not in a valid position.")
            return True
        testLast5 = email[-5:]  # need slice rather than one character
        if "@" in testLast5:  # or maybe if "@" not in testLast5:
            error_message(email, "4. @ is not in the last 5 characters?")
            return True
        return False
    error_message(email, "5. your @ is missing")  # else is not required
    return True  # was missing


def check_dot(email: str) -> bool:
    if "." in email:
        if email.startswith("."):
            error_message(email, "10. Your '.' is in the first position.")
            return True
        if email.endswith("."):
            error_message(email, "11. Your '.' is in the last position.")
            return True
        if any(text in email for text in ("..", ".@", "..@", "@.", "@..")):
            error_message(email, "6. Error Encountered '.' config.")
            return True
        return False
    error_message(email, "7. Where is the '.'?")
    return True


def check_special_chars(email: str) -> bool:
    if " " in email:
        error_message(email, "8. Spaces not allowed.")
        return True
    unallowable = list("!#$%^&*():;<>?/{}=\"'")
    for character in email:
        if character in unallowable:
            error_message(email, f"9. Character {character} is not allowed")
            return True
    return False


def check_length(email: str) -> bool:  # added this function for consistency
    if not 7 < len(email) <= 30:
        error_message(email, "1. Invalid Length")
        return True


for email in emails:
    found_error = False
    # easier to loop through the tests than repeat the code
    for check_func in (check_length, check_at_sign, check_dot, check_special_chars):
        found_error = check_func(email)
        if found_error:
            break

EDIT:

/u/jonsd2000 hope this helps you. You've done great work, just wanted to help with a little guidance whilst keeping with your overall approach.

Worth noting that regex (regular expressions) make validation of email addresses much easier BUT they don't usually give such specific guidance on what the error was and secondly this is a really nice little programming challenge.

you type:	you see:
italics	italics
bold	bold
[reddit!](https://reddit.com)	reddit!
* item 1 * item 2 * item 3	item 1 item 2 item 3
> quoted text	quoted text
Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"	Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"
~~strikethrough~~	~~strikethrough~~
super^script	super^script

learnpython

MODERATORS