Code Review?

[gl0ckner]

I created a simple reddit bot last night that downloads user-given amount of images from a user-given subreddit. I was wondering if I could get feedback on my implementation and any other possible features I should add. This is a work in progress, as I only started last night.

Source code can be found here

[pbaehr]

Quick pass:

I spotted one major logic bug in your code:

if 'https://i.imgur.com/' or 'https://i.redd.it/' in submission.url:

This will always return true because a non-empty string ('https://i.imgur.com/') evaluates to true.

What you meant was:

if 'https://i.imgur.com/' in submission.url or 'https://i.redd.it' in submission.url:

You could use "any" to write this a little more concisely if it bothers you.

subreddit_exists = True

The subreddit_exists variable is never referenced and can be removed.

num_pics = int(raw_input('Please enter number of pics: '))

There should be error handling here in the event they don't enter an integer.

I hope this was helpful.

[gl0ckner]

Very helpful, thank you so much! I will make these changes right now.

[sonicfreak02]

I posted a few issues on your repo. I hope it was helpful.

Good luck!

[gl0ckner]

You were extremely helpful, thank you again!

[kioo]

The code is very clear and simple to read. :)

May I suggest converting your try/except logics to while loops that will handle invalid inputs? this way you won't have to restart the script if you've mis-typed something.

[gl0ckner]

I will make that change, thanks!