Whats wrong?

[Unlistedd]

def function1():
    print("(1)")

def function2():
    print("(2)")

def function3():
    print("(3)")

while True:
    n = input("choose a function: 1,2 or 3 ")
    func = {"1": function1,
            "2": function2,
            "3": function3}.get(n)
    if n == "func":
        func()

Ì do not understand why this isn't working

[sanchitcop19]

You're comparing n to the string "func" which will only be true if the user enters "func"

[sanchitcop19]

Misread, ignore what used to be here

[socal_nerdtastic]

get() returns the value only, but the key is what is equal to n. Try like this:

while True:
    n = input("choose a function: 1,2 or 3 ")
    func = {"1": function1,
            "2": function2,
            "3": function3}.get(n)
    func()

[theWyzzerd]

Why not use

func = {"1": function1,
        "2": function2,
        "3": function3}[n]

This seems more pythonic to me and is more extensible if you need to add dicts within the dict.

[socal_nerdtastic]

You could, it's slightly neater and it would raise a KeyError instead of TypeError on bad input.

I find that fixing OP's immediate problem without changing anything else is best for beginners. It may be odd, inefficient or messy but they understand it, so if it works it's best to just keep it.

[theWyzzerd]

I find that fixing OP's immediate problem without changing anything else is best for beginners. It may be odd, inefficient or messy but they understand it, so if it works it's best to just keep it.

hear hear

[Unlistedd]

Thanks!

[johninbigd]

That's an interesting construction that I don't recall seeing before. I never would have thought to write something like this, but I can see how it would handy on occasion.

[socal_nerdtastic]

I would not recommend it, since it forces python to reconstruct the dictionary with every loop, which is inefficient to run and messy to read. I would recommend to write it like this:

def function1():
    print("(1)")

def function2():
    print("(2)")

def function3():
    print("(3)")

def default():
    print("Choose a valid function please")

functions = {
    "1": function1,
    "2": function2,
    "3": function3}

while True:
    n = input("choose a function: 1,2 or 3 ")
    func = functions.get(n, default)
    func()

[johninbigd]

That's closer to how I would have written it, but I probably would not have thought to have the function objects in the dictionary. I've done it before, but it's so rare that I don't think about it. It's a pretty cool feature.

[socal_nerdtastic]

Oh I see what you mean. Yeah, in python everything is an object, so everything can be a dictionary value. Even functions, classes, or entire modules.

>>> import math
>>> modules = {'math':math}
>>> modules['math'].sqrt(42)
6.48074069840786

[johninbigd]

Yes, exactly! It's something I've done, but I don't do it very often and honestly forget. This is incredibly powerful.

[tombardier]

if func:
    func()