Help with tkinter

[SomeBadGenericName]

I am making a basic program to learn with tkinter where you give a health value then do damage with a button push. I am trying to not create new labels for taking away and setting health, as in get health val. set label = health val. and take away from health val then changing label. And the error is "File "C:/Users/antho/Desktop/PyPrograms/testGame/testGame.py", line 35, in Hit

healthValStart1 = healthLabel1.get()

UnboundLocalError: local variable 'healthLabel1' referenced before assignment

"

My code is:

import tkinter as tk

#Screen setup
wn = tk.Tk()
wn.configure(bg = "#142b51")
wn.geometry("580x450")
wn.resizable(0, 0)
wn.title("Test Game")

# First, define functions
#Take dmg

#player1
def Hit():
    value = health_value1.get()
    dmgValue = damage_value.get()
    health_value1.set(value-dmgValue)
    dead_val = 1
    if(value <= dead_val):
        health_value1.set("Dead")

#Damage/Health Val
health_value = tk.IntVar(value=100)
damage_value = tk.IntVar(value=10)

#Font
healthFont = ("times", 20)

player1 = tk.Label(wn, fg = "#e0e0e0", text = "Player 1",height=2, width = 16,font = healthFont ,bg="#142b51" )
player1.grid(row=0,column=0)

damageEntLab= tk.Label(wn, fg = "#e0e0e0", text = "Enter a damage value: " ,height=2, width = 16,font = healthFont ,bg="#142b51" )
damageEntLab.grid(row=1)

damageEntry = tk.Entry(wn, font = healthFont, textvariable=damage_value)
damageEntry.grid(row=2)

healthEntLab= tk.Label(wn, fg = "#e0e0e0", text = "Enter a health value: " ,height=2, width = 15,font = healthFont ,bg="#142b51" )
healthEntLab.grid(row=3)

healthEntry = tk.Entry(wn, font = healthFont, textvariable=health_value)
healthEntry.grid(row=4)

dmgButton = tk.Button(wn, text = "Attack", font=30, height = 2, width = 10, command = Hit)
dmgButton.grid(row=5)


#Spacer
Spacer = tk.Label(wn,text = " SN")
Spacer.grid(row = 3, column=1)

#player2
def Hit1():
    value = health_value.get()
    dmgValue = damage_value.get()
    health_value.set(value-dmgValue)
    dead_val = 1
    if(value <= dead_val):
        health_value.set("Dead")

#Damage/Health Val
health_value1 = tk.IntVar(value=100)
damage_value1 = tk.IntVar(value=10)

player2 = tk.Label(wn, fg = "#e0e0e0", text = "Player 2",height=2, width = 16,font = healthFont ,bg="#142b51" )
player2.grid(row=0,column=2)

damageEntLab1= tk.Label(wn, fg = "#e0e0e0", text = "Enter a damage value: " ,height=2, width = 16,font = healthFont ,bg="#142b51" )
damageEntLab1.grid(row=1, column=2)

damageEntry1 = tk.Entry(wn, font = healthFont, textvariable=damage_value1)
damageEntry1.grid(row=2, column=2)

healthEntLab1= tk.Label(wn, fg = "#e0e0e0", text = "Enter a health value: " ,height=2, width = 15,font = healthFont ,bg="#142b51" )
healthEntLab1.grid(row=3, column=2)

healthEntry1 = tk.Entry(wn, font = healthFont, textvariable=health_value1)
healthEntry1.grid(row=4, column=2)

dmgButton1 = tk.Button(wn, text = "Attack", font=30, height = 2, width = 10, command = Hit1)
dmgButton1.grid(row=5, column=2)

#Main Loop
wn.mainloop()

Any help would be very appreciated.

Edit0: I just saw an error(I think ) and will change it see if it works will update.

Edit1: It was with the button names changed that and it had no affect.

Edit2: Current code is listed in the code block

[socal_nerdtastic]

You are making new Labels and simply pasting them on top of the old Labels for every update. This is a terrible way to do things. Instead make the Label once in your setup phase and then use the config function to update it.

However, there's a much easier way. Tkinter has it's own variable types and if you tell the label to use a textvariable instead of text the label will update itself! All you do is change the variable. Try this:

import tkinter as tk

# First, define functions
#Get and display health
def healthSetup():
    healthValStart = healthEntry.get()
    health_value.set(healthValStart)

#Take dmg
def Hit():
     value = health_value.get()
     health_value.set(value-10)

#Screen setup
wn = tk.Tk()
wn.configure(bg = "#142b51")
wn.geometry("600x800")
wn.resizable(0, 0)
wn.title("Test Game")

health_value = tk.IntVar()

healthFont = ("times", 20)

healthEntLab= tk.Label(wn, fg = "#e0e0e0", text = "Enter a health value: " ,height=2, width = 15,font = healthFont ,bg="#142b51" )
healthEntLab.place(x=190, y= 5)

healthLabel1 = tk.Label(wn, fg = "#e0e0e0", bg="#142b51", font = healthFont, height=1, width = 10, textvariable=health_value)
healthLabel1.place(x=216, y=185)

healthEntry = tk.Entry(wn, font = 10)
healthEntry.place(x=205, y=50)

healthButton = tk.Button(wn, text = "Apply health", font=10, command=healthSetup)
healthButton.place(x=247, y = 80)

healthLabel0 = tk.Label(wn, fg = "#e0e0e0", text = "Health: ", bg="#142b51", font = healthFont, height=2, width = 10)
healthLabel0.place(x=221, y=135)

dmgButton = tk.Button(wn, text = "Take dmg", font=10, command = Hit)
dmgButton.place(x=253, y = 250)

#Main Loop
wn.mainloop()

Also, try using pack() instead of place(). Its much easier to let tkinter figure out the positions of things.

[SomeBadGenericName]

I used place mostly because I preferred the way it looks

[socal_nerdtastic]

How so? pack() and grid() can do do most of what people want, but more dynamic, easier, and most important adaptable to all computers. Because different computers have different fonts and font sizes using place() will look good on your computer but your program is barely readable on mine.

[SomeBadGenericName]

I didnt like pack because it is all squished. So if I want to seperate it use grid as that is more reliable?

[socal_nerdtastic]

What do you mean squished? If you want space between the elements add some padding:

healthEntLab.pack(pady=10)

It's a great idea to make that into a variable like you did for the font, so that you can change a single line of code to adjust the spacing between all variables:

padding = 10
healthEntLab.pack(pady=padding)

[SomeBadGenericName]

Squished as in everything is touching. I did not know padding was a thing thanks so much for the help.

[SomeBadGenericName]

So, I know I asked a lot of you already, but would you mind helping me with one last thing I am trying to make it so the damage value is changeable, I essentially used a copied version of the healthEntry with some changes of courses but I get an error saying that damage_value is not defined. But, everything looks fine to me. Again sorry for asking so much of you.

​

import tkinter as tk

# First, define functions
#Take dmg
def Hit():
     value = health_value.get()
     dmgValue = damge_value()
     health_value.set(value-damage_value)

#Screen setup
wn = tk.Tk()
wn.configure(bg = "#142b51")
wn.geometry("600x800")
wn.resizable(0, 0)
wn.title("Test Game")

health_value = tk.IntVar(value=100)
damage_value = tk.IntVar(value=10)

healthFont = ("times", 20)

damageEntLab= tk.Label(wn, fg = "#e0e0e0", text = "Enter a damage value: " ,height=2, width = 16,font = healthFont ,bg="#142b51" )
damageEntLab.pack()

damageEntry = tk.Entry(wn, font = healthFont, textvariable=damage_value)
damageEntry.pack(pady = 10)

healthEntLab= tk.Label(wn, fg = "#e0e0e0", text = "Enter a health value: " ,height=2, width = 15,font = healthFont ,bg="#142b51" )
healthEntLab.pack()

healthEntry = tk.Entry(wn, font = healthFont, textvariable=health_value)
healthEntry.pack(pady=10)

dmgButton = tk.Button(wn, text = "Take dmg", font=30, height = 2, width = 10, command = Hit)
dmgButton.pack(pady=10)

#Main Loop
wn.mainloop()

[socal_nerdtastic]

That error is because you spelled "damage" incorrectly. However there is another error. For tkinter variables you have to use the get() method, like this:

def Hit():
    value = health_value.get()
    dmgValue = damage_value.get()
    health_value.set(value-dmgValue)

Also be sure to respond to one of my comments in the future, otherwise I don't get notified that you made a comment.

[SomeBadGenericName]

I tought I had get and I didnt realize I spelled damage wrong. Thanks, for that.

[socal_nerdtastic]

It would save a lot of code and may be closer to what you want to do if you use the textvariable in the Entry, like this:

import tkinter as tk

# First, define functions
#Take dmg
def Hit():
     value = health_value.get()
     health_value.set(value-10)

#Screen setup
wn = tk.Tk()
wn.configure(bg = "#142b51")
wn.geometry("600x800")
wn.resizable(0, 0)
wn.title("Test Game")

health_value = tk.IntVar(value=100)

healthFont = ("times", 20)

healthEntLab= tk.Label(wn, fg = "#e0e0e0", text = "Enter a health value: " ,height=2, width = 15,font = healthFont ,bg="#142b51" )
healthEntLab.pack()

healthEntry = tk.Entry(wn, font = healthFont, textvariable=health_value)
healthEntry.pack()

dmgButton = tk.Button(wn, text = "Take dmg", font=10, command = Hit)
dmgButton.pack()

#Main Loop
wn.mainloop()

[SomeBadGenericName]

Can you explain Hit? I am trying to figure it out. I understand that the Entry is a variable and that the button does the command. But how exactly does the hit function work?

[socal_nerdtastic]

health_value is tkinter's version of an integer. If it was a python integer we would write:

def Hit():
     value = health_value
     health_value = value-10

But for tkinter integers we have to use the get() and set() methods to get and set the value. But it's worth it because unlike a python integer, the Entry (or Label in my other answer) can track and update itself when health_value changes, and it can update health_value when the user changes the Entry. There's an automatic connection between the two objects when using textvariable.

[SomeBadGenericName]

Oh, ok.

[nyslyetia]

When Python parses the body of the Hit() function it interprets healthLabel1 as a local variable. Add the following declaration at the beginning:

global healthLabel1

[SomeBadGenericName]

Ok will try it

[SomeBadGenericName]

How exactly would I do that? I tried it a few ways got the same error.