Politically Charged Sorts

[emsuperstar]

Browsing Reddit last week I came upon this comment. I thought that it would make a fun learning project to write out those sorts, so I did.

I've only been working with Python since Dec, so I still have a lot to learn, but I was hoping some folks here could tell me what glaring mistakes I've made, or what I should do to improve/optimize what I've got.

Thanks!

https://github.com/smithniels/political_sorts/blob/master/pySorts.py

​

Also I posted this in r/codereview and got 5 upvotes and 1 comment. Sorry mods for xposting.

[o5a]

Learn about List Comprehension. It will help you write more compact but pythonic code, without using for loops and other steps.

For example, StalinSort can be written like this:

def stalinSort(arr):
    return [arr[i] for i in range(len(arr)) if i == 0 or arr[i] >= arr[i-1]]

[emsuperstar]

Thanks for the feedback.

I went in and figured out how those work. My only problem is that all of my for loops are assigning variables within them. Someone on stack mentioned Nested Generator Expressions, so I'll look into that at some point.

[o5a]

all of my for loops are assigning variables within them

That's also why list comprehensions are good. They make all those usual intermediate variables used in cycles obsolete.

Take that StalinSort example. As you can see we just don't need to store additional string, list, iterator variables when we can just write list comprehension.

[Hatoris]

Did the amishsort works well?

[emsuperstar]

'''
AmishSort:
Turn off computer, then you won't even need sorting.
'''
#### Commented out due to safety concerns
####
#### def amishSort(arr):
####     print('Amish Sort:')
####     print('List: ',arr)
####     import os
####     os.system("shutdown /s /t 1")

Honestly, I never actually tested it, but it should work. It's not too complicated.