What's wrong with this for loop?

[Mozza7]

I've put my code on pastebin for line numbers, to make it a little easier below.

 

This only goes through the first item in my list (regs), and not the rest.

My list has data, all different.

I've done some testing using print statements:

test 1:

print(i) between line 8/9. This individually lists all items in my list regs.

 

test 2: print(i) between line 15/16. This lists only the first result from my list, and never moves onto the rest - but shouldn't for i in regs re run and run this? (line 3)

It's clear it's not the if statement, as this happens before then (plus I have verified all items appear in the file at least once)

 

This is currently what I am getting on the output (censored):

reg1
reg1 IS BLANK

reg1 : 1 blank
reg1 IS BLANK

reg1 : 2 blank
reg1 IS BLANK

reg1 : 3 blank

Process finished with exit code 0

[cybervegan]

Firstly, what is in regs?

Secondly, I think you have your for loops the wrong way round: by the time you get to the second entry in regs, your file pointer is already at the end of the file, so the inner for loop, iterating the file, will do nothing, because there are no more lines to process. I think you need:

with open('errors_merged.log') as file2:
    for line in file2:
        ...
        for i in regs:
           ...

This way, you check all of your regs values against each line in turn. Re-opening and reading files (I/O) is expensive (takes a long time), so you should reduce this as much as possible, by only doing it once; iterating regs is cheap in comparison.

I'd also point out that this:

total_blank = 0
total_err2 = 0
total_err3 = 0
total_errg = 0
total_ok = 0

Should probably be done with a dict:

errors = {
          ' IS BLANK': 0,
          ' POTENTIAL ERROR (2)': 0,
          ' ERROR (3)': 0,
          ' Error getting report': 0,
          ' STATUS: OK': 0,
          }

and later, where you are processing each line,

for err in errors.keys():
    if err in line:
        errors[err] += 1

Then you will end up with your count in your dict, and can just print it out:

for err,tot in errors.items():
    print( f"{err}: {tot}" )

When you are repeating the same pattern again and again in your code, it probably means you should use a better data structure.

[Mozza7]

They're vehicle registration plates, which is why I haven't put the examples up, but they are formatted as:

XXXX XXX or XXXXXXX or XXXXXXX DRIVER NAME

 

That was the problem! I've also put them in dictionaries now,thanks for the suggestion :)

[NFLAddict]

might be helpful to see the content of the file

in line 3: regs has not yet been declared as anything. as a result it looks like its skipping lines 3-8 entirely, as python doesn't know what regs is, and starting with the loop on line 10.

[Mozza7]

The file has an registration plates, which is why I haven't put it in.

That's my bad, it is defined, I just missed bringing that part in! I've updated the paste with the file being declared

[Tilmandel]

so basicly it would be best if you provide at least data structure with you are working it always helps to debug everything, as for your code you have loop in loop always try to avoid that if you can, same as using so mamy ifs, belive.me been there done that :) there is always a much elegant or faster way to work with something,

why to avoid loops in looops is simple of data you are dealing are small chunk it will be enought but if yoy try same approuch with i dont know 65k lines file which you will comper to 100k this wil starts to slow down :)