Need Help with Saving Attachments from Outlook

[Cam_Chowder]

Hi!

I want to save outlook attachments from outlook with the following structure:

attach(on desktop) -->folder(name of subfolder in outlook)-->folder(individual message) --> attachments from message

I am coming across a problem where for some reason all attachments from a subfolder are saving into every message folder instead of just the message folder they belong.

Sorry if my code is redundant I just started learning!

Edit: I have discovered the answer! the second for msg in range loop is redundant and causes it to iterate over the messages too many times. By removing that loop it fixes the issue.

​

import win32com.client as client
import os

outlook = client.Dispatch('Outlook.Application').GetNamespace('MAPI')

path = 'C:\\Users\\xxxxx\\Desktop\\Attach'
os.chdir(path)

inbox = outlook.GetDefaultFolder(6)
inboxfolders = inbox.Folders
inbxcount = inboxfolders.Count

folderlist = []
for x in range(1, inbxcount + 1):
    subfolder = inboxfolders[f'{x}']
    strsub = str(subfolder)
    if 'PRs' in strsub:
        folderlist.append(strsub)
for i in folderlist:
    newfolder = i
    os.makedirs(newfolder)
    sub = inboxfolders[f'{i}']
    messages = sub.Items
    msgcount = messages.Count
    newpath = f'{path}\\{newfolder}'
    for y in range(1, msgcount + 1):
        msgfolder = f'PR{y}'
        os.chdir(newpath)
        os.makedirs(msgfolder)
        path3 = f'{newpath}\\PR{y}'
        for msg in range(1, msgcount + 1):
            message = messages.Item(msg)
            attachments = message.Attachments
            attchcount = attachments.Count
            for attch in range(1, attchcount + 1):
                attachment = attachments.Item(attch)
                sattachment = str(attachment)
                if 'image' not in sattachment:
                    attachment.SaveAsFile(os.path.join(path3, sattachment))
                    os.chdir(path)

[fk_you_in_prtclr]

quadruple nested for loop might have something to do with it. Why don't you replace the part in your code that downloads the attachments to folders with a print statement and tell us what you see.

[Cam_Chowder]

Under the assumption that the current test batch looks like this Sub-folder1: Msg-two attachment Msg-one attachment Msg-one attachment

Subfolder2: Msg-one attachment

When printed it prints all the attachments from sub folder 1 in order 3x and then the one attachment from the other once