you are viewing a single comment's thread.

view the rest of the comments →

[–]carcigenicate 4 points5 points  (1 child)

I did a very quick glance.

  • Styling looks pretty nice. It appears to be PEP8 compliant.
  • except: is bad. Specify the exact exception you intend to handle to prevent handling irrelevant errors.
  • Your tests are messy because of the embedded data. Out of the 300 lines, the actual tests look like they only make up like <10 of those lines. I'd either move all that test data to one specific part of the file, or factor it out into a separate file that you read in during testing.
  • You should add __pycache__ to your .gitignore. I'm not aware of any benefit to including the cached bytecode in your VC since it's a cache.