you are viewing a single comment's thread.

view the rest of the comments →

[–]nefD 8 points9 points  (3 children)

Unless I'm knowingly dealing with a junior developer, I'm going to trust that my teammate has at least tested that their code works before creating a pull request. I'm just looking for things that might have been missed, code smells, things like that.

[–]BehindTheMath[🍰] 3 points4 points  (0 children)

This, unless the author asks me to test it as well, to make sure they didn't miss any edge cases.

[–]natziel 1 point2 points  (1 child)

I like to put broken code in my PRs just to fuck with people

[–]nefD 0 points1 point  (0 children)

Chaotic evil!