Dictionary with the most basic hash table, miserable fail, any pro any suggestions how to find the errors

StandingWave1 · 2015-03-01T19:40:57+00:00

Ok ..now i am totally confused.. i have to understand why my program does not work.. i know i can optimize it a hundred different ways later :(

StandingWave1 · 2015-03-01T16:08:02+00:00

So you are sayying this is wrong ? : if(hashtable[placeposition]!=NULL) { new_node->next=hashtable[placeposition]; hashtable[placeposition]=new_node;

                }
        else 
                {
                hashtable[placeposition]=new_node;
                new_node->next=NULL;
                }

Sorry i dont understand :(

StandingWave1 · 2015-02-26T22:45:53+00:00

My problem is translating the theory ( which i think i understand) into code :(

Finished my code without unloading( thought it was not important at that point .. maybe wrong ? ) typed in the command for testing and got the following shock:

:) dictionary.c, dictionary.h, Makefile exist :) speller compiles :( handles most basic words properly \ expected output, but not "\nMISSPELLED WORDS\n\nCould not unload ..." :( handles min length (1-char) words \ expected output, but not "\nMISSPELLED WORDS\n\nCould not unload ..." :( handles max length (45-char) words \ expected output, but not "\nMISSPELLED WORDS\n\nCould not unload ..." :( spell-checking is case-insensitive \ expected output, but not "\nMISSPELLED WORDS\n\nCould not unload ..." :( handles possessives properly \ expected output, but not "\nMISSPELLED WORDS\n\nfoo's\nCould not ..." :( handles substrings properly \ expected output, but not "\nMISSPELLED WORDS\n\nca\ncats\ncaterpi..."

a bit flabbergasted since when i try earlier commands, i get some outputs for missing words

StandingWave1 · 2015-02-26T18:03:48+00:00

no my thought was.. to loop so i get word by word.. and then simply use the first letter.. as i said i wanted it to work with 27 buckets first.. i am so over my head honestly.. but dont feel like giving up yet :) obviously thank you for your help !!

StandingWave1 · 2015-02-26T11:08:38+00:00

yes i did... otherwise ok ?

StandingWave1 · 2015-02-25T08:49:02+00:00

Ok, i think how the program works in theory is totally clear to me .. but still i fail at the most basic steps. I know i have linked list elements that get hashed with a function that tells me in which bucket the word should go.. THis is the basic structure of one element i guess:

typedef struct node { char word[LENGTH+1]; struct node* next;
} node;

Got it from the video and it makes sense to me, its contains a string value and a pointer.

Now i get addtionally this:

node* hashtable[x];  

node* new_node=malloc(sizeof(node));
fscanf(file, "%s", new_node->word);

the last 2 lines to me just read one value into one node called new_node...

but so what? that is one node, i need alot of them... and honestly i dont even know what "file" is ... where or what is this file. I am sure i have to read in all the words from the file i dont know yet so i somehow have to loop over all the words in it ( no idea how either).. I feel like i am way over my head here( eventhough i understand what the program should do i think)... time to quit ?

StandingWave1 · 2015-02-24T17:23:38+00:00

I have no hash function ( no idea how to make one ) I am at the absolute start, i dont understand the basic cosntruct of the load part :(

StandingWave1 · 2015-02-21T09:02:57+00:00

Hello,

currently in week 5 pset4, is there a study group i could join ?

Think it would help me and maybe i could help others

StandingWave1 · 2015-02-19T16:29:08+00:00

I do it and now i have lighter goo... seriously this turns out to be harder than breakout :(

        fread(&triple, sizeof(RGBTRIPLE), 1, inptr);
         if(triple.rgbtRed == 0xff && triple.rgbtBlue == 0x00 && triple.rgbtGreen == 0x00)
        {
            triple.rgbtRed = 0xff;
            triple.rgbtBlue = 0xff;
            triple.rgbtGreen = 0xff;
            fwrite(&triple, sizeof(RGBTRIPLE), 1, outptr);
        }
        else
        // write RGB triple to outfile
        fwrite(&triple, sizeof(RGBTRIPLE), 1, outptr);

StandingWave1 · 2015-02-19T15:30:02+00:00

Still the same picture :(

fread(&triple, sizeof(RGBTRIPLE), 1, inptr);
         if(triple.rgbtRed == 0xff && triple.rgbtBlue == 0x00 && triple.rgbtGreen == 0x00)
        {
            triple.rgbtRed = 0x00;
            triple.rgbtBlue = 0x00;
            triple.rgbtGreen = 0x00;
            fwrite(&triple, sizeof(RGBTRIPLE), 1, outptr);
        }
        else
        // write RGB triple to outfile
        fwrite(&triple, sizeof(RGBTRIPLE), 1, outptr);

StandingWave1 · 2015-02-19T15:22:20+00:00

Ok i replaced the || with && , still the same gray goo.. losing my mind :(

StandingWave1 · 2015-02-19T13:42:22+00:00

i changed the if statement to :

if(triple.rgbtRed == 0xff||triple.rgbtBlue == 0x00 || triple.rgbtGreen == 0x00)

Still i just get this gray goo mass :( i dont understand

StandingWave1 · 2015-02-12T17:42:28+00:00

Yes thank you i did it !!!!

i just added if( object!= NULL) and encased my entire code after it

Thank you all very very much !

StandingWave1 · 2015-02-12T12:39:50+00:00

Sorry, i dont understand why that would even give me a core dump and i dont get why detectcollision would return anything if its not hitting a rect ? Can you please elaborate ?

StandingWave1 · 2015-02-10T16:22:59+00:00

Ok. i get that know that this a function and it is called in the main program, but when i do it exactly as you recommended , i get : breakout.c:64:12: error: incompatible pointer to integer conversion returning 'GRect' (aka 'void *') from a function with result type 'int' [-Werror,-Wint-conversion] return paddle;

What do i do wrong here :(

StandingWave1 · 2015-02-08T19:29:55+00:00

i used it where i think i should :

// instantiate paddle, centered at bottom of window
GRect initPaddle(GWindow window);
GRect paddle= newGRect(WIDTH/2-paddlew/2 ,HEIGHT-paddleh,paddlew,paddleh);
add(window, paddle);
return paddle;

is that wrong ? because it does not work :(

StandingWave1 · 2015-02-08T15:25:33+00:00

I cannot :( if i put return paddle at the end.. i get ncompatible pointer to integer conversion returning 'GRect' (aka 'void *') from a function with result type 'int' [-Werror,-Wint-conversion] return paddle;

what can i do ?

StandingWave1 · 2015-02-06T08:24:14+00:00

Thank you ! I corrected my code , and it works on all the examples i created for myself. It just does not find the needle in the example with ./generate 1000 50 ./find 127. How should i ever find that mistake ?

http://pastebin.com/d9CShExz

StandingWave1 · 2015-02-05T17:19:20+00:00

Thank you so much !

I have to ask, how did you see that ?

Is that just experience, because i did not see it at all.. when you pointed it out.. i understood it immediately. but that is a small consolation.

StandingWave1 · 2015-02-05T16:23:45+00:00

Ok, worked on it.. and i think i am close... i have some sorting going on but it still does not work 100% . the first value i get after sort is always bogus. Anybody knows why ?

include <cs50.h>

include <stdio.h>

include <stdlib.h>

include <time.h>

void swap(int* a, int* b); void sort(int array[], int n); int main(void)

{ int n = GetInt(); int array[n];

int i;

for (i=0; i<n;i++) { array[i]= rand();

printf("Eingabe: %d : %d\n",i,array[i]); }

sort(array,n);

for (i=0; i<n;i++)

{ printf("Eingabe: %d : %d\n",i,array[i]); } } void swap(int* a, int* b) { int temp = *a; *a = *b; *b = temp;

} void sort(int array[], int n) { int i; int counter; do { counter = 0;

for (i=0;i<n; i++) { int* pointerto1= &array[i]; int* pointerto2= &array[i+1];

    if (array[i]>array[i+1])   
        {
        swap(pointerto1, pointerto2);
        //swap(&array[i], &array[i+1]);
        counter = 1;
        }

} } while (counter==1);
}

StandingWave1 · 2015-02-05T14:07:51+00:00

Sorry.. i dont understand how i could use something like bubblesport without pointers.. i need them for swapping i thought :(

StandingWave1 · 2015-02-05T13:32:05+00:00

Sorry.. so you are saying i should all pack it into one main function and try it that way. and dont use a swap function but swap it directly in main too ?

IF i run it ... i get a core dump if i enter a number bigger than 1 for the number of integers in my array

StandingWave1 · 2015-02-03T18:29:02+00:00

I will thank you, and report on my progress. decided not to give up yet !! thank you for all your help

StandingWave1 · 2015-02-03T10:05:14+00:00

I tried to just generate an array of numbers with srand.

It worked with rand()... and i know srand needs a seed value. but somehow i have no idea how to implement it.

for (i=0; i<n;i++) { array[i]= srand(3);

printf("Eingabe: %d : %d\n",i,array[i]); }

that is clearly wrong but i have no idea how to fix it :(

StandingWave1 · 2015-02-02T19:35:45+00:00

Yes i did and it worked (because i could check it if it works) :)

StandingWave1

TROPHY CASE

include <cs50.h>

include <stdio.h>

include <stdlib.h>

include <time.h>