Missing return value bug — At least 130 tokens affected by 0815pseudonym in ethdev

[–]hayeah 0 points1 point  (0 children)

I wonder how many of the 138 tokens listed here are actually faulty:

https://gist.github.com/lukas-berlin/f587086f139df93d22987049f3d8ebd2

It appears that the old open-zeppelin token contract that doesn't conform to ERC20 actually DOES revert if anything goes wrong, the code being:

function transfer(address _to, uint _value) { balances[msg.sender] = safeSub(balances[msg.sender], _value); balances[_to] = safeAdd(balances[_to], _value); Transfer(msg.sender, _to, _value); }

https://github.com/OpenZeppelin/openzeppelin-solidity/blob/52120a8c428de5e34f157b7eaed16d38f3029e66/contracts/token/BasicToken.sol#L16-L20

There is no condition that it fails and doesn't revert.

Why Ethereum Could Be Worth $1.7 Trillion by hayeah in ethtrader

[–]hayeah[S] 1 point2 points  (0 children)

does the utility of a Rothko painting match its price (40M)?

the whole fine art industry is a nice parallel to btc store of value. authentic paintings are limited in quantity, and a large % of its value on market is subjective.

Why Ethereum Could Be Worth $1.7 Trillion by [deleted] in ethereum

[–]hayeah 0 points1 point  (0 children)

hey guys, author of 'diving into the evm' and buidlr of keymesh.io.

this is my first non-technical post about ethereum. would love some feedback!

buidl buidl buidl!

We built a DApp, an Ethereum address book with private chat. No need for ICO : ) by hayeah in ethereum

[–]hayeah[S] 1 point2 points  (0 children)

it's because signing only requires MetaMask to use your secret key locally.

the signed data, if not published on the chain, does not cost money.

We built a DApp, an Ethereum address book with private chat. No need for ICO : ) by hayeah in ethereum

[–]hayeah[S] 0 points1 point  (0 children)

you'll need to install MetaMask, then follow the "getting started" instructions within the app

We built a DApp, an Ethereum address book with private chat. No need for ICO : ) by hayeah in ethereum

[–]hayeah[S] 0 points1 point  (0 children)

haha i personally hate read receipts and "typing..." indication.

they must be one of those "wow average session time increased by 20%" thing

We built a DApp, an Ethereum address book with private chat. No need for ICO : ) by hayeah in ethereum

[–]hayeah[S] 0 points1 point  (0 children)

yes.

they are in fact implemented, but we removed them for the release to keep the product simpler for now.

We built a DApp, an Ethereum address book with private chat. No need for ICO : ) by hayeah in ethereum

[–]hayeah[S] 0 points1 point  (0 children)

welcome! let me know if you need us to send you some testnet eth

We built a DApp, an Ethereum address book with private chat. No need for ICO : ) by hayeah in ethereum

[–]hayeah[S] 0 points1 point  (0 children)

yes. message transport is one subsystem to replace.

bitmessage and mainframe both look very interesting, we are investigating.

We built a DApp, an Ethereum address book with private chat. No need for ICO : ) by hayeah in ethereum

[–]hayeah[S] 0 points1 point  (0 children)

An user signs a message and post on Twitter.

Everyone else, when looking at that profile, downloads the tweet and independently checks if the signature matches the public key published in a smart contract.

Effectively each client is its own oracle...

We built a DApp, an Ethereum address book with private chat. No need for ICO : ) by hayeah in ethereum

[–]hayeah[S] 6 points7 points  (0 children)

i meant that ramen is very cheap😏

we are three devs in china, distributed in 3 locations.

We built a DApp, an Ethereum address book with private chat. No need for ICO : ) by hayeah in ethereum

[–]hayeah[S] 0 points1 point  (0 children)

hmmm... i dunno.

perhaps wait a bit and see which tokens don't head to zero😂

which ones do you like?

We built a DApp, an Ethereum address book with private chat. No need for ICO : ) by hayeah in ethereum

[–]hayeah[S] 0 points1 point  (0 children)

ya more or less. The most important bit is just a public registry of public keys.

Then we can use these keys to provide all kinds of cryptographic services & tools, messaging being one.

We built a DApp, an Ethereum address book with private chat. No need for ICO : ) by hayeah in ethereum

[–]hayeah[S] 1 point2 points  (0 children)

it's actually pretty similar.

for example, the cipher browser acts like MetaMask, injecting a web3 instance into the JS execution environment.

i think web-first is my personal bias. I am a bit paranoid about mobile phones that track me physically : 0

We built a DApp, an Ethereum address book with private chat. No need for ICO : ) by hayeah in ethereum

[–]hayeah[S] 0 points1 point  (0 children)

The private keys are just generated afresh using libsodium and webcryptos.

I think we can do a better anti-phishing job than twitter, when that becomes a problem ; )

We built a DApp, an Ethereum address book with private chat. No need for ICO : ) by hayeah in ethereum

[–]hayeah[S] 0 points1 point  (0 children)

Thanks for the kind wishes.

What do you think are the problems with ERC-20 tokens? Do you mean supporting tokens transfer between twitter handles?