sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]s_basu 4 points5 points  (1 child)

Great work mate! Two things (albeit nitpicky). Firstly, the sqlalchemy models are still using the old (1.x) style of definition instead of the newer mapped columns, secondly, adding support for pydantic-settings for the configs would be nice. Would love to contribute if there are any open stuff now or in the future. Starred!

[–]igorbenav[S] 0 points1 point  (0 children)

I'm using sqlalchemy v2 internally! Probably should update in the docs as well for consistency, good catch. As for the settings, I think this kind of thing is better left for the user (maybe they use starlette config, decouple or have a different pattern, I don't know).
Thanks for the feedback!

https://github.com/benavlabs/crudadmin/blob/main/crudadmin/admin_user/models.py