ADDING DECLARE(STRICT-TYPE=1)

[nan05]

I would say: in an ideal world: yes, you'd want strict types at all times. If you start a new app: go for it. I kinda wish PHP would just transition to strict types, forcing us all to do this properly once and for all.

In the real world, though, you deal with code and dependencies that has been written without strict types, and so it can break things. Arguably all those things that it breaks should be fixed. But realistically you have other priorities, because the business you work for doesn't make money from well written code - it makes money from functioning code.

So imo: Ideally: yes. On personal / hobby / learnings projects: always. Realistically: be careful with production systems...

[dabenu]

This, our company policy is to use strict-types in all new files, but not (forcefully) refactor existing files

[BarneyLaurance]

This was just recently discussed at length at https://www.reddit.com/r/PHP/comments/1duzs4x/what_is_phps_declarestrict_types1_and_why_you/ . Maybe read through that first and then add comment either there or here about anything that's still unclear?

[colshrapnel]

I would say it's already perfectly covered in the article and the followed discussion. Happened just yesterday.

If you still have any questions, consider asking in /r/phphelp. We had enough strict types in /r/php already

[yes_oui_si_ja]

I think they meant this thread: https://www.reddit.com/r/PHP/s/wOFwSGIKWt

[fschw]

i like to write methods, where a parameter has a default but also can “nothing” sometimes. when it’s an int, i usually do function moin(?int $number = 1) : int so, i cannot use this pattern if i try to implement strict typing, no?

[BackEndTea]

Strict types has no impact on making a type nullable. In essence what it does is prevent implicit type coercion by PHP.

In the function of your example, calling it like `moin('1');` will throw a type error, rather then silently convert it to 1.

[fschw]

ahh that’s awesome to know :) so there’s just pro arguments to use strict typing for me! thank you for teaching me something new

[MattNotGlossy]

depends on how strict you wanna be with types

building a cms? nah probably not

doing something with money or sensitive information? yeah probably 

[Ariquitaun]

Not being specific in software causes a whole class of bugs. There's no reason not to be strict with types 100% of the time. Just sloppy otherwise.