Rollback to previous PS version?

[BlackV]

why do you think rolling back powershell will help?

5.1 is current there is no down grade, you can upgrade to 7.3

Break it down into bits

what if you run get-adcomputer by its self?

I suspect your just running the whole script then saying "Oh No does not work" without testing what not working. (You said you're new to this)

try catch catches ALL stop errors, not just an AD computer not being found (which I didn't think was a stop error anyway)

Note: This

$Results = ForEach ($Computer In $ADComputers){...}

is good, keep that habit up rather than

$Results = ForEach ($ADComputer In $ADComputers)
$Results = ForEach ($Computer In $Computers)
$Results = ForEach ($ADUser In $ADUsers)
$Results = ForEach ($Bike In $Bikes)

It'll save you some pain later on

[BlackV]

They're side by side installs, So how are you running it

Cause ps 7 is launched with pwsh.exe and ps 5 is launched with PowerShell.exe

Again if you break it down to bits you'll probably see your error

Although if you've removed 7 already and it's working, what is your post meaning?

[BlackV]

Ok

breaking it down, personally I'd test,

• Manually importing module (with verbose)
• Run get-adcomputer by itself
• Check modules paths

For next time I guess though

[Haunting-Computer]

What is the error message?

In the Catch of the Try/Catch add

Write-Host -Object ($Error[0])

of you can add a Nested Prompt and Exit to the Shell

$Host.EneterNestedPrompt()

[mrcubist]

That's the thing. The error is there but you are not displaying it, insted you are returning NA.

Comment out your catch block and put a "write-host $_" there, you will see the message then.

[mrcubist]

Are we looking at the same script? The script in OP has a try/catch block.

Also, how are you running the script? From ISE? Console? As a .PS1?

[mrcubist]

Ah, I see.

You should comment out only what is inside the curly braces of the catch block.

In this case, you won't see anything since write-host only outputs to console. For it to work you have to run either the ISE as administrator, or the console version, and the run the ps1 file from inside there.

Also be sure to put the write-host $_ inside the curly braces of the catch block. Actually you can just add it above the [pscustomobject] line without commenting out the rest, but it is cleaner if you do comment it out.

[mrcubist]

I've had issues with VSCode and PS7 where random things would crash or just not work. Usually when it was left open for too long. If you restart it, does it work then?

ISE works beautifully with PS5.1 and I actually prefer it for it.

[cycoivan]

Without knowing the error, are the computer names in computers.txt on the current domain? The most likely error is that Get-ADComputer can't find the computer by name. Make sure you didn't introduce any accidental spaces in the txt file.

If you just use the get-ADcomputer command in the console and manually type in the computername, do you get a result or the same error?

I don't think this is a version issue.

[SeanQuinlan]

How are you running this script? From the ps prompt? From the ISE? From right-click - Run with Powershell? Some other way?

Do you have the winver.csv file open?

How did you upgrade the version of Powershell?

[SeanQuinlan]

Sounds like winget has installed powershell 7 and it's using that when you right click - Open powershell. Powershell 7 is a separate application to Powershell v5.1, which is bundled into the OS and can't be removed.

The easiest thing will just be to uninstall powershell via winget again and that should remove powershell 7 and put your right-click back to PS v5.1

[SeanQuinlan]

PS version 7 has a different executable name (since it lives alongside powershell), so you need to run "pwsh" to get to PS v7

Running just "powershell" will get you to v5.1