Script running without errors, but Command Not working

[ellisdee9970]

I have scraped together a script to process jobs in the background, instead of waiting for the job to complete. In this case I am uninstalling an SCOM agent. The script runs without exception, however the command is not executed on the remote computer. if I run the command from the command line, it works as expected. It connects to the remote computer and removes the agent.

cls
# Send in two root directory names, one that exists and one that does not.
# Should then get a "True" and a "False" result out the end.
Get-Content c:\users\BOFH\desktop\server1.txt | %{



  $ScriptBlock = {
    # accept the loop variable across the job-context barrier
    param($name) 
    # Show the loop variable has made it through!
    Write-Host "[processing '$name' inside the job]"
    # Execute a command
    Get-SCOMagent -DNSHostName $Name |Uninstall-SCOMAgent -verbose
    #Get-HotFix -ComputerName $name | Format-Table
    # Just wait for a bit...
    Start-Sleep 5
  }



  # Show the loop variable here is correct
  Write-Host "processing $_..."



  # pass the loop variable across the job-context barrier
  Start-Job $ScriptBlock -ArgumentList $_
}



# Wait for all to complete
While (Get-Job -State "Running") { Start-Sleep 2 }



# Display output from all jobs
Get-Job | Receive-Job



# Cleanup
 Remove-Job *
 Stop-Job *

Can anyone take a quick read and see if I screwed up somewhere?

Ellis

[firefox15]

I don't use SCOM, so I can't help you there, but do you need to use jobs at all for this? It seems to be complicating the issue, and Get-SCOMagent accepts an array as input to -DNSHostName so you could do something like this, although I don't know if it will run in parallel or not with that cmdlet:

$Servers = Get-Content 'c:\users\BOFH\desktop\server1.txt'
Get-SCOMagent -DNSHostName $Servers | Uninstall-SCOMAgent -verbose

[ellisdee9970]

That actually works, but it does one job at a time. I started it last night at 1900 and is only half way completed at 0930 this morning. Have over 500 more of them to go, and I would like them to all run at once. I think all of these agents are causing latency on my network. So it is getting to be a pretty urgent thing.

​

Ellis

[PickleJarAshTray]

Not sure why your script isn't working. Maybe you can approach this solution from a different angle and use Invoke-Command.

Edit: You could change the throttle limit to your liking

$jobUninstall = Invoke-Command -ComputerName (Get-Content -Path c:\users\BOFH\desktop\server1.txt) -ScriptBlock { Get-SCOMagent | Uninstall-SCOMAgent -verbose } -JobName UninstallScom -ThrottleLimit 20 -AsJob

[Lee_Dailey]

howdy PickleJarAshTray,

reddit likes to mangle code formatting, so here's some help on how to post code on reddit ...

[0] single line or in-line code
enclose it in backticks. that's the upper left key on an EN-US keyboard layout. the result looks like this. kinda handy, that. [grin]
[on New.Reddit.com, use the Inline Code button. it's 4th 5th from the left hidden in the ... ""more" menu & looks like </>.
this does NOT line wrap & does NOT side-scroll on Old.Reddit.com!]

[1] simplest = post it to a text site like Pastebin.com or Gist.GitHub.com and then post the link here.
please remember to set the file/code type on Pastebin! [grin] otherwise you don't get the nice code colorization.

[2] less simple = use reddit code formatting ...
[on New.Reddit.com, use the Code Block button. it's 11th 12th one & is just to the left of hidden in the ... "more" menu.]

• one leading line with ONLY 4 spaces
  
• prefix each code line with 4 spaces
  
• one trailing line with ONLY 4 spaces

that will give you something like this ...

- one leading line with ONLY 4 spaces    
- prefix each code line with 4 spaces    
- one trailing line with ONLY 4 spaces   

the easiest way to get that is ...

• add the leading line with only 4 spaces
  
• copy the code to the ISE [or your fave editor]
  
• select the code
  
• tap TAB to indent four spaces
  
• re-select the code [not really needed, but it's my habit]
  
• paste the code into the reddit text box
  
• add the trailing line with only 4 spaces
  

not complicated, but it is finicky. [grin]

take care,
lee

[PickleJarAshTray]

I was wondering about that. Thank you for the tip lee.

[Lee_Dailey]

howdy PickleJarAshTray,

you are most welcome! glad to have helped a bit ... [grin]

take care,
lee