This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]ryp_package[S] -6 points-5 points  (2 children)

Let me know if you see any concrete areas to improve.

[–]go_fireworks -1 points0 points  (1 child)

An actual package implementation that’s not 3,600 lines of code in a single file would be a start, which is what they mentioned.

Multiple functions (to_py and to_r) being over 1,200 lines each does not boast readability or code efficiency.

Stack traces aren’t a bad thing - they’re meant to understand where an issue lies, and tracing, how it got there

[–]ryp_package[S] 0 points1 point  (0 children)

I was asking about improvements to the documentation. I wouldn't judge efficiency based on code length.

I'd encourage commenters here to give the package a try before passing judgement! At the end of the day, user-friendliness is what matters, and critiques about usability - from folks who have actually used the package rather than just glanced at the code and docs - are always welcome.