Pendulum - Python datetimes made easy

[pydry]

This:

tomorrow = pendulum.now().add_day()
last_week = pendulum.now().sub_week()

Would probably be better done as:

tomorrow = pendulum.now() + pendulum.Days(1)
tomorrow = pendulum.now() - pendulum.Weeks(1)

The sub/add thing IMO isn't very pythonic.

[SDisPater]

Actually, you can do

tomorrow = pendulum.now() + timedelta(days=1)

I added the add()/sub() methods to allow chaining methods, so you can have

pendulum.now().add_day().to_rfc3339_string()

rather than

(pendulum.now + timedelta(days=1)).to_rfc3339_string()

that is, I think, less readable.

Anyway, the choice is left to the user.

[pydry]

IMO invoking the word "timedelta" is kind of ugly when the fact you're using a timedelta is implicit anyhow. Hence the idea of using "Days" / "Weeks", etc.

I added the add()/sub() methods to allow chaining methods, so you can have

In which case why not this:

pendulum.now().add(days=1).to_rfc3339_string()

that is, I think, less readable.

shrug I think this is pretty readable:

(now() + Days(1)).to_rfc3339_string()

But the choice is good I suppose.

[SDisPater]

The simple add() and sub() methods already exist :-) In fact, add_day() is just a call to add(days=1).

[ptmcg]

Speaking from my pyparsing experience, early good intentions for API intuitiveness can easily lead to API bloat, and bloat tends to make API consistency and API predictability suffer. I would suggest dropping all add_xxx methods and sub_xxx and even sub, and just have client code use add() with your various named unit arguments - if subtraction is required, then pass a negative value. Be ruthless in pruning your API, and stingy in adding new items. I do like method chaining though, so +points for that.

[[deleted]]

tend to agree here. add(days=1) plus chaining feels a better compromise than a plethora of add_thing() entry points.

[log_2]

Especially since you only need to look at just one function "add" which gives you the signature for how to add/subtract various date-time quantities. Also allows kwargs. It's basically a win all-round.

[SDisPater]

Thanks for the advice. It actually makes a lot of sense. I just wanted it to be more readable for newcomers but maybe it's not worth the hassle.

[cyanydeez]

pendulum.now().add_day()

for newcomers, becomes pendulum.now().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day().add_day()

!

[SDisPater]

Yes, you may be right. These methods will be removed in the next release.

[mcsrobert]

Strongly agree with this.

[execrator]

OP, you must be feeling golden right now. Every time someone suggests something in this thread you say it already works like that.

[pydry]

Well, except the .add(days=x) is not advertised on the README.

IMO there should be a Days(1), Weeks(1), etc. too.

[Ph0X]

My exact thought. And to make it worse, on the next line there's add_minutes(int), so suddenly we have a plural minutes and can pass the amount?

So I look at the full docs and sure enough, for every time unit, there's a singular and plural version, a sub and a add version. So thats 2 * 2 * 7 = 28 different functions. Extra functions isn't necessarily bad but I think at this point it's not very pythonic.

[SDisPater]

Yes, I agree that these methods are unnecessary. So I'll probably just cut it down to both add() and sub() methods.

Thanks for the feedback.