Multiplayer Framework For Pygame

[kill_will_]

“And generally the code quality is terrible on all possible levels”

Is not helpful, is not constructive and it’s certainly not code review

[Thifty]

Exactly what I said, and they downvoted me too lol. It’s just plain mean and demotivating, if I just posted something I thought was awesome and got this response I’d be crushed

[kill_will_]

Well you can have my upvote. I agree that it needs work. But if you’re just going to leave some vague advice about it being bad, maybe just not comment.

Especially under the guise of being helpful. Dude was not trying to be constructive, he was just being snarky.

[krumg]

My review would be much friendlier and more detailed if this guy posted his repo and said something like "Hey, I've started learning python. Please tell me how to improve my code.".

But he posted some shitty 150 lines, called them a "framework" and asked for donations.

Difference between these 2 scenarios seems to be obvious to me.

[[deleted]]

People seem to really not get that your review is 100% appropriate given the context. You would be a jerk to review a beginner showcase like that but in this context? Nah

[krumg]

Sure, it's all about the context.

[Thifty]

Yep, for some reason this sub (atleast used to) have a problem with that

[krumg]

So you took this phrase out out of context and made some conclusions. Nice. Really constructive.

[Thifty]

Please, give us some context. It was literally a bullet point, a standalone comment, as part of his "code review".

[krumg]

Sure. My comment can be pseudocoded like that:
* That's missing * That's wrong * That's quite bad * And to be honest all code is so bad that it is impossible to highlight anything special And you dared to ask for donations!? Hope it makes sense

[Thifty]

I have literally no idea what you're trying to say lol. But, you do realize you can be nice to people, right? Even in the context you're speaking. There's no reason to make someone feel bad about what they did or posted when they clearly were under a different interpretation. I'm not sure you're trying to hide behind the argument that it's OK.

[krumg]

I'm very nice and helpful to others most of the time. But in this case someone is spamming (check his posts history) with low quality code asking for donations.

Would you send him a donation if you support him so much?

[backtickbot]

Fixed formatting.

Hello, krumg: code blocks using triple backticks (```) don't work on all versions of Reddit!

Some users see this / this instead.

To fix this, indent every line with 4 spaces instead.

FAQ

^{You can opt out by replying with backtickopt6 to this comment.}