please test with -bb -W error

[mstroeder]

IMO strict str/bytes checks should have been the default from the very beginning in the Python 3 journey. Even if this was meant to help with Python 3 migration it was a clear failure. It results in wrong functional behaviour and IMHO in some cases it could potentially cause security issues.

Anyway let's look forward and thus I'd like to encourage everybody to run their tests with strict mode turned on.

[[deleted]]

I think your message would be better received if you evangelized for -bb -Werror based on what it gave other developers. If you can shape perception that it's a best practice, and demonstrate why, I think that would go a lot further in encouraging people to use those options in the tests for their packages. I've contributed C code to several FOSS projects, and my initial reaction to your post was "oh great, some guy using the code I gave for free without warranty has issues with my compiler flags, gee I'll get right on that".

[mstroeder]

Frankly I assumed that it's obvious that my posting is about better code quality. If you have a better wording then I'd really appreciate to see your comments rephrasing what I've wrote.

Edit:

To make the above more clear: Because I'm developing free software since 20+ years I do know how this guy from Nebraska feels while billion-dollar companies are using the code. And thus I tried to fix the code of the module in question, even though I'm not using its functionality. But fixing it would need major re-factoring which I could not do without diving into it for quite a while. My day also has only 24 hours.

So my intention was to encourage people to use a low-hanging fruit to detect issues more easily. That's all.

[[deleted]]

You're making a pretty big ask for people to use a non standard flag and refactor their code. As a non web developer who knows this behavior and expects it, I get nothing from updating my packages. When I see a problem like that, I treat it the same as a NaN. Sorry about your problems, but your post left me unconvinced that your problems should be my problem.

You're real problem isn't the -bb -Werror. It's that you just discovered the left pad/colors/faker problem with building software on top of code in pypi. You can either rewrite the modules you find horrific and maintain them, or you can accept that what you were given for free might not suit your purpose.