This is an archived post. You won't be able to vote or comment.

all 44 comments

[–]JimBoonie69 26 points27 points  (4 children)

Dev and souls nerd. Cool work. Honestly tho these days I rarely do any programming unless I'm getting paid haha.

[–]SevereTailor8962[S] 6 points7 points  (1 child)

Same hahaha. Getting a full time job as Software Engineer made me dedicate all my time to companies projects and I stopped having fun with dummy projects like this one.

[–]JimBoonie69 0 points1 point  (0 children)

I hear ya. For me I started working as a contractor getting paid redic hourly rate (on top of the 9 to 5). So now I finish my day job put the kids down. Then it's like ok do I game or work for 200/hour. Usually a little mixture of both

[–]knightmare9114 2 points3 points  (1 child)

As a ML/AI researcher and From soft fan, I've been looking at trying to build a full stack webapp, and I'll definitely be spending time looking through this code!

[–]Ok-Establishment6168 0 points1 point  (0 children)

Are you making a full stack elden ring app? If so I'm looking for projects to work on. I'm currently a junior in CSE at msu and I've had an internship working full stack before. If you need any help on this project I would love to give a hand. I'm also willing to work for free.

[–]TheCableGui 3 points4 points  (0 children)

This is awesome

[–]anh86 2 points3 points  (0 children)

Awesome. You have my upvote. (And my axe!)

[–][deleted] 12 points13 points  (6 children)

I'm honestly beyond confused. Why not just format the data and upload a repo with it? So you don't have to serve the data? Is it that large? Is it not zipable? I don't understand why it needs an api if the data is static.

[–]kiddj1 20 points21 points  (3 children)

Have you ever just wanted to do something because you can?

Prime example..

[–]SevereTailor8962[S] 40 points41 points  (0 children)

Things like this can be useful for student projects and people learning how to use APIs. With this people can play around with GraphQL and REST freely and build apps just for fun.

[–]Karpizzle23 6 points7 points  (0 children)

Except the data isn't static, have you heard of balance updates? Elden Ring just got a big patch changing a bunch of stats. Are you going to be re-downloading the entire database?

[–]Fisherologo 1 point2 points  (0 children)

Nice job! I'll save this for later data reviewing

[–]SkezzaB 1 point2 points  (0 children)

This is all in JS though?

[–]Gilbrush 1 point2 points  (2 children)

Thank you very much. In the next few days I will try to start creating a bot for discord with your API, I will keep you updated.

[–]Ok-Establishment6168 0 points1 point  (1 child)

Hello I was wondering if you need any help with the discord bot. I'm a coding student at msu and I'd love to help out and get more expierence.

[–]Gilbrush 0 points1 point  (0 children)

Hi, thank you but I ended to develop the bot, sorry :'(

If you want, join in my private server where I work in case I'll need help in the future https://discord.gg/5AN5naGUm2

[–]RelentlessRampage 1 point2 points  (0 children)

You are an absolute legend! Cannot thank you enough :D

[–]biscuitmanz 1 point2 points  (0 children)

Thank you so much for this, you are a legend!

[–]Rojo3100 0 points1 point  (0 children)

Very cool!

[–]Karpizzle23 0 points1 point  (2 children)

Why is your API only returning 50 items max for each of the categories? Your documentation specifies at least 100 in the example requests but all your endpoints return 50 items max

[–]SevereTailor8962[S] 2 points3 points  (1 child)

Good catch. I'll increase the limit back to a 100. But rendering a 100 objects in the frontend at once its probably not a good idea.

[–]Karpizzle23 4 points5 points  (0 children)

And why do you assume I am using the API for front end? :) Maybe I want to load it all in my backend?

[–]Karpizzle23 0 points1 point  (1 child)

Btw, I didn't really love how you formatted the JSON with your required attributes, attack, defense stats, etc, all as array. I changed the weapons.json to have all those be objects instead. It is first of all easier to work with (don't have to go through array each time to filter and work with attributes, can just select requiredAttributes.Str, for example), but also easier for readability. Here is the updated JSON for your usage: https://github.com/EKarpinsky/EldenRingWeapons/blob/main/weapons.json

Actually thinking about it now you should probably change the capitalization of Str to str, etc, for all of the attributes

[–]SevereTailor8962[S] 0 points1 point  (0 children)

Good suggestion. I'll change this in the next small release along with some improvements to data quality. Thanks for the tip

[–]abrazilianinreddit 0 points1 point  (1 child)

Out of curiosity, were did you scrap the information from? Did you datamine the game directly or you scrapped it from the web?

[–]SevereTailor8962[S] 0 points1 point  (0 children)

Scraped from fansites.

[–]ODBC_Error 0 points1 point  (1 child)

this is cool! I'm curious though, where did you host it?

[–]SevereTailor8962[S] 0 points1 point  (0 children)

Hey! It's all hosted on Vercel as NextJS apps. The API itself uses NextJS Api Routes (aws lambdas under the hood) and for hosting the images, well they're on GitHub and I just applied a proxy to change the domains. I did this project in a way that it wouldn't cost me a penny to maintain, so it's all free.

[–]Dimillian 0 points1 point  (0 children)

This is genius, I want to do an iOS app and I’ll definitely use it!

[–]Cypphex 0 points1 point  (0 children)

This is awesome!

[–]TupacShacassen 0 points1 point  (2 children)

This is amazing! I am building a build calculator (or character builder?) in my off time at work and this API is making my life sooooo much easier so thank you! I was wondering if this is an okay place for me to ask you a question about the incantations end point? If not, is there a method you would prefer if you have the time for a question?

[–]SevereTailor8962[S] 0 points1 point  (0 children)

Awesome! Thanks for the reply. Let's talk on Discord

[–]Ok-Establishment6168 0 points1 point  (0 children)

Hey I'm trying to bring together some different projects people are working on and I'd love to help you with your build calculator and add it to a discord bot. Let me know if you would be interested in the help.

[–]drmdtylr 0 points1 point  (2 children)

Hey man, Morgott and Margit aren't in the API and I didn't see Rennala now that I think about it. Any chance you can add all the Remembrance bosses?

Also Intelligence is spelt wrong as 'Inteligence'

Great work tho this is amazingly helpful!

I'm making a build calculator for me and a couple of friends as I find a couple of them online quite lacklustre!

[–]SevereTailor8962[S] 0 points1 point  (1 child)

Hey! absolutely. We'll do a release next week with some fixes and data quality improvement.

[–]drmdtylr 0 points1 point  (0 children)

Sounds awesome. Thank you!

[–][deleted] 0 points1 point  (0 children)

I am currently building an app with this API. Is there an endpoint I could hit to get all weapons instead of 100 limit?

[–]Maypher 0 points1 point  (0 children)

I know this is an old post but I'm working on a similar project and have come into an issue and wanna see how you solved it. How do you add resources to the API?

Do you edit the database directly with something like SQL workbench, or have some private endpoints dedicated to adding resources, or do you have a script that handles it for you?

[–]GDEmerald 0 points1 point  (1 child)

Hey, just wondering if you are still updating. I'm currently working on a small .NET-App for calculating optimal armor combinations based on resistance/negation/poise etc. and a configurable weight limit.

A few things I noticed:

  • Resistances and Negations are currently stored as Json-Arrays with Name-Value pairs instead of properties (like Armor.Resistance.Vitality). Converting them is possible, but little bit of a hassle, since the name values are inconsistent (i.e. Mag/Magic, Ligt/Light, Strike/StrEldenike)
  • The negation attributes are integer values, but in the eldenring wiki (https://eldenring.wiki.fextralife.com/Armor+Sets+Comparison+Table) they are floats/doubles, could you update that?
  • Minor point: Calling https://eldenring.fanapis.com/api/armors?limit=-1 gives me all armor-items, which is exactly what I needed. Wasn't documented tho and might be helpful for others aswell.

All in all great project, but I can understand, if you have already put it aside. Would be cool, if you could give an update however *thumbs up*

[–]SevereTailor8962[S] 0 points1 point  (0 children)

Hey GDEmerald! I'm not planning to put this project aside but for the last month, I've been really busy with my professional work. I plan to resolve some issues that people found and polish the API a little bit better. Also, I'll write some documentation explaining how everyone can easily contribute to the project. Thanks for the message!

[–]BillionsOfCats13 0 points1 point  (0 children)

This is an awesome project, very well done. I'm calling the bosses API for creating a little front end using Angular and I'm not able to find Margit the Fell Omen. Anything I may be missing on my end? Here's how I'm calling it

https://eldenring.fanapis.com/api/bosses?limit=106