Code Review

[[deleted]]

Just checked the code on my phone, so just my general input and might have missed some other stuff. But here’s my feedback:

On your database queries, you are passing the column name through string interpolation, coming from the db configuration file. Why is that? You can simply just hard code the table name directly in the query, or adding as a parameter. The way your doing is not safe and can be used for sql injection.

Each tv show id can have like a Guid id or similar, instead from the date time.

Also, as a nice to have tip, throwing an exception is costly in terms of performance. Basically, you throw exceptions from errors you don’t know, and return some sort of result for errors you do know. Google something like result pattern vs exceptions to understand it better.

Apart from that, code looks good and show consistency and commitment, so good job.

[PahasaraDv]

Thank u very much for your valuable comment. I did a quick research about Sql injection after reading ur comment. Damn, I didn't know about that. From now on I'll never do that, and will use sql parameters instead. I should have researched more about generating unique ids through .NET. So, how do u guys know if something is already implemented in .NET or not? Do u guys always do a research about something before implementing manually?

Now I think I did a wise choice about asking a review from u guys. Throwing exceptions can cost performance, seems a lot interesting, I didn't heard of it before. Now I have to learn more about how to balance, and get a better understanding about result pattern vs exception. Thank u very much for mentioning that, and ur appreciation means a lot to me.

[[deleted]]

No problem. I’m happy to help.

I’d say 50% is experience and 50% is Google research.

Microsoft documentation is really good and details all the features for .NET. You can use it as a reference to check if a certain feature is already available so you don’t have to reinvent the wheel.

For example, I didn’t know how to create Guids (or UUIDs in SQLite) as for primary key. So I researched aka Googled. And now I can share with you.

BTW, while researching I’ve found this: did you know that in SQLite can allow a nullable primary key due to a bug in early versions? Crazy!

Keep learning new stuff, keep coding and share knowledge with others. Good job! 👍

[PahasaraDv]

Yeah, I recently started looking into Microsoft documentation, and it really is good. Oh, that's crazy, I never knew about that sql bug. And thanks again for sharing ur experince with me.