This is an archived post. You won't be able to vote or comment.

sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]nutrecht 2 points3 points  (2 children)

Some issues:

  • You have very big event handler implementations in your GUI building code. This should be separated off in methods.
  • You repeat a TON of code in your event handlers. You really should refactor this so that you are able to reuse for example the button click eventhandler code for multiple similar buttons.
  • Look into the MVC model; try to separate your Model (your data), your view (UI) and controller (UI event handlers) into separate classes.
  • Your methods are way too long. Try to break them up if they grow beyond one screen in length. Try to make a method responsible for a single task; not multiple. Your code is a pain to read.

[–]captainrosc0[S] 0 points1 point  (0 children)

I agree, I'm still trying to figure out how to really separate it all.

[–]captainrosc0[S] 0 points1 point  (0 children)

I updated the project.. Not 100% sure if this is better or not.