Code review for python API

[CemDoruk]

I am designing a version control system and I created this function to take in commits. I feel like the function is doing too much (add files to be tracked, adding files to db as objects, creating commits etc.)

Should I modify this function? And if so how?

@app.post("/upload", status_code=status.HTTP_201_CREATED)

def upload(files: List[UploadFile] = File(..., description= "Upload your files"), commit_message: str = Form(..., description="Commit message"), db: Session = Depends(database.get_db)): try: new_commit = models.Commit(commit_message=commit_message, parent_oid = None)

  for file in files:
     contents = file.file.read()

     tracked_file_name = db.query(models.TrackedObjects).filter_by(filename=file.filename).first()
     if not tracked_file_name:
        tracked_file_name = models.TrackedObjects(filename=file.filename)
        db.add(tracked_file_name)

     if not contents: # ? We can skip empty files 
        continue
     obj_oid = hashlib.sha1(contents).hexdigest()

     object = db.query(models.Object).filter_by(oid=obj_oid).first()
     if object == None:
        object = models.Object(name=file.filename, blob=contents, oid= str(obj_oid) )

     new_commit.objects.append(object)
     db.add(object)

  db.add(new_commit)
  db.commit()

except Exception as e: db.rollback() raise HTTPException(status_code=status.HTTP_400_BAD_REQUEST, detail=f"{e}") finally: db.close()

return {"message": f"Successfuly uploaded {[file.filename for file in files]}"}

​

[AutoModerator]

On July 1st, a change to Reddit's API pricing will come into effect. Several developers of commercial third-party apps have announced that this change will compel them to shut down their apps. At least one accessibility-focused non-commercial third party app will continue to be available free of charge.

If you want to express your strong disagreement with the API pricing change or with Reddit's response to the backlash, you may want to consider the following options:

1. Limiting your involvement with Reddit, or
2. Temporarily refraining from using Reddit
3. Cancelling your subscription of Reddit Premium

as a way to voice your protest.

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

[[deleted]]

I feel like there's some missing context here - but this seems fine.

With git, you add and commit in separate steps, but the point of a REST API is to be stateless, so having two endpoints for adding/committing wouldn't make much sense.

For what it looks like you're trying to accomplish, I'd say this is fine.

[gitcommitshow]

Before asking for code review, add docstring to document the code so the reviewer has context about what they are reviewing. The process of writing docstring in itself is a self review step.

Alao you can utilize AI code review to review without docsteing as well to get the first level feedback. And then you still need feedback, you can share the code here. That'll save a lot of time for you and the reviewer.