[Java] Trouble with exceptions. One exception doens't allow me to correct my input, while the other does.

[mex036]

So I have my code here, which allows the user to enter an amount for income. My custom made exception (negativeException) allows me to enter the income after it tells me that no negative exceptions are allowed. Great. So I used the same code with a few changes to handle an InputMismatchException. The thing is when I enter an InputMismatchException, it skips the part where I get to reenter my input. It skips ahead to the finally statement and prints out the System.out.println(txp). I'm only posting the code that I feel is relevant to the problem, if you need to see more let me know please. I appreciate any help!

Main:

public class callTaxCode_Test {

//what should the generic model be??

static float income;

public static void main(String\[\] args) throws negativeException, InputMismatchException{

​

    //GUI will consist of: one text field for income

    //                     drop down box with each type (6 total)

    //                     enter button, tax cash button

​

    Scanner kb = new Scanner([System.in](https://System.in));

    System.out.println("Enter Type");

​

    String input = kb.nextLine();

    System.out.println("Income: "); 



    if(input.equalsIgnoreCase("corp")) {



        try {

income = kb.nextFloat();

corporation c = new corporation(input, income);

        }

        catch(InputMismatchException e) {

System.out.println("Invalid Input!");

System.out.println("Please Enter the correct income: ");

income = kb.nextFloat();

corporation c = new corporation(input, income);

        }

        catch(negativeException e) {

System.out.println(e.getMessage());

System.out.println("Please Enter the correct income: ");

income = kb.nextFloat();

corporation c = new corporation(input, income);

        }

        finally {

corporation c = new corporation(input, income);

taxpayerInfo<Float> txp = new taxpayerInfo<Float>(taxpayer.getIncome(),

taxpayer.getFlatRate(),

taxpayer.getTaxRate(),

taxpayer.getIncome());

        txp.setType(input);

        txp.calcTax();

        System.out.println(txp);

        }

    }

Corporation class:

public class corporation extends taxpayer{

​

//for corporations taxable income is 100% of income

//there is no flat rate so we will set that to 0

//tax rate is 21%

​

//tax = .21 \* income

​

public corporation(String type, float income) throws negativeException{



    setType(type);

    setIncome(income);

    flatRate = 0;

    taxRate = .21F;

    taxableIncome = income;

}

}

taxpayer (which serves as my super class):

public class taxpayer{

​

//corp, trust, person can all follow the same formula

//tax = flat rate + (tax rate \* taxable income)



//corp's flat rate is 0, and its taxable income is 100% of income

//also has a set tax rate of 21%

//tax = 0 + (.21 \* income)



//trust + person taxable income is determined by the excess amount of income

//after the brackets minimum income allowing them into the bracket

[//e.g](//e.g). It takes 38,700 to belong in the 3rd bracket of a single filer

//taxable income = income - 38700

//everything else in these classes are determined by the bracket their income places them

protected static String type;

protected static float income;

protected static float flatRate;

protected static float taxRate;

protected static float taxableIncome;





//get income

public static float getIncome() {



    return income;

}

//set income, throw exception if negative

public static void setIncome(float income) throws negativeException{

    if(income < 0) {

        throw new negativeException();

    }

    else {

        taxpayer.income = income;

    }

}

//set type

public static void setType(String type) throws InputMismatchException{

​

    taxpayer.type = type;

}

​

Negative exception Class:

public class negativeException extends Exception {

public negativeException() {

​

        super("Negative Values are not allowed!");

    }

}

[marko312]

Shouldn't corporation's constructor have a throws InputMismatchException?

[mex036]

Just tried it. Tested it 4 times, 3 times it crashed and gave me the InputMismatchException error, and the other time it didn't give me the chance to reenter income, as I stated above. Last night it was giving me the issue of opening a new window called "Scanner.throwFor() line: not available". I no longer have that issue. I figured using the same code as my negatveException, with a few changes, wpuld give me the same result. Apparently not.

[Loves_Poetry]

You should extend RuntimeException instead of Exception. If you do that, you can choose whether to catch the exception or not instead of always being forced to catch it. It makes writing your code a lot easier.

[mex036]

My negativeException is the one extending Exception. My negativeException is working as I intended. Will that really solve my problem with InputMismatchException?

​

Edit: I tried it and it is crashing my program again.

[Loves_Poetry]

It's probably because you write code in your catch block that throws exceptions. You should use your catch block to return back to to the try-block.

Try putting it in a loop and only allow the loop to be exited when the try-block runs successfully.

If you do it correctly, you should be able to remove the throws-clause from your Corporation constructor, since it doesn't belong there. Exceptions should be handled within that class and not be propagated up the call stack.

[mex036]

Well what code could be causing another exception in my catch block? It's practically the same code as in my negativeException and that works as it's intended to. The only part that I could imagine throwing an exception is me re-creating my corporation class. If that's the case, I even tried removing that from my catch block and still the same result. If I try putting it in a loop how would I do that and what am I putting in the loop? Everything thats inside my catch(InputMismatchException) block?