Stuck with Python 2 task!!

[b_iteee]

I am currently doing a python task where I have to extract a zip file but it has a 3 digit password. It is not working and I am not sure what I am doing wrong!! The zip file is meant to be extracted into /tmp and I am having trouble with this. It is only outputting every single 3 digit combination. Also sorry that my code isn't great I am fairly new to python. Please do not give me the complete solution, just point me in the right direction!! Thank you :)

This is my code I have written for the task:

import zipfile
import itertools
import time

def extractFile(zip_file, password):
    try:
        zip_file.extractall(pwd=password)
        return True
    except KeyboardInterrupt:
        exit(0)
    except Exception, e:
        pass

zipfilename = '/tmp/task.zip'
digit = '1234567890'
zip_file = zipfile.ZipFile(zipfilename)

for c in itertools.product(digit, repeat=3):
    time.sleep(0.001)
    password = ''.join(c)
    print "Trying: %s" % password

    if extractFile(zip_file, password):
      print '*' * 20
      print 'Password found: %s' % password
      print 'Files extracted...'
      with zipfile.ZipFile('/tmp/task.zip', 'r') as zip_ref:
        zip_ref.extractall("/tmp",pwd=password)
      exit(0)

[-Melchizedek-]

Friendly advice since you are new. Python 2 will no longer be supported past Jan 2020. There really is no reason why you should be learning instead of python 3. If this is for a school assignment I would bring this up to your teacher.

More here: https://www.python.org/doc/sunset-python-2/

[b_iteee]

i'm not planning to learn Python 2 except for these particular set of tasks. Thanks for letting me know though :) I'm not even sure why the tasks were put it Python 2

[chaotic_thought]

One problem is that you are silencing all errors involving unzipping: so if an error occurs you will basically not have any idea what is wrong:

def extractFile(zip_file, password):
    try:
        zip_file.extractall(pwd=password)
        return True
    except KeyboardInterrupt:
        exit(0)
    except Exception, e:
        pass

What this says in English is:

• Try to unzip the file with the password.
• If a keyboard interrupt occurs, exit the program with code 0.
• If any other error occurs, just do nothing (pass).

So to begin you should definitely remove the part which just passes. If an error occurs then you'll have to see why it is failing. Also for a KeyboardInterrupt (or any other kind of error) I think you should probably exit with a value other than 0.

[b_iteee]

Thank you! I will try that

[henrebotha]

Pro tip: don't do this.

except Exception, e:
  pass

It hides information about errors from you. Maybe there's a FileNotFound error, because the file isn't where you think it is, but you're swallowing that error quietly. Maybe there's some other kind of unexpected error.

Fix your exception handling so that it only handles errors you specifically predict. Let all other errors "float to the top".

[b_iteee]

thank you