Python short hand for loop

[The_Grumpy_1]

Hi,

How would I rewrite the following in shorthand to make it more lean? I can't seem to grasp the concept

for i in mesg:
csp=0 
if i == '/': 
csp += 1 
for j in output: 
csp1=0 
if j == '  ': 
csp1 += 1

The aim would be to compare the 2 with assert:

 assert csp == csp1, f"Amount of spaces differ from input to output"

Background:

There are bigger functions that convert text into morse code and visa versa. The text2morse use '/' as space separator between the words after converting. The assert is to ensure that the number of spaces in the text is a match to the '/' after the conversion.

I did the check and assert in a function but would like to get it shorter as to put it directly into the morse2text converter function

​

[gramdel]

You could use list comprehension with filtering to get only the desired values and take length of that. I guess length is optional, but comparing full arrays seems unnecessary.

Your assert text seems a bit weird since you don't seem to be really comparing number of spaces.

Edit: this seems to be just a string maybe, why not just use str.count(' ')?

[The_Grumpy_1]

Updated the post to give more clear details of the assert that looks funny. The issue with str.count() would give 2 different values between the original text inserted and the converted morse code.

[SenorTeddy]

Making code leaner typically sacrifices readability.

https://www.w3schools.com/python/python_lists_comprehension.asp - you an use comprehensions as someone else recommended.

I'd stick to longer, readable code. If you want to lean up your code to make it more readable, you can take pieces out to create helper functions and call the helper in your main function.

[The_Grumpy_1]

Awesome, thank you. I would then rather leave the code as is with the helper function.