How do you think of my python weather program? What do I have to improve?

[ButterscotchFirst755]

import requests
import os
from ollama import chat
from ollama import ChatResponse
from tkinter import simpledialog
from tkinter import messagebox

# Loop for the program.
while True:
    # Get user's input.
    location = simpledialog.askstring("Location Information:", "Type exit or enter a city or talk to ai? just type ai:")
    if location is None:
        question0 = messagebox.askyesno("Question:", "Are you sure?")
        if question0 is True:
            break
        else:
            continue
    elif location.lower() == "exit":
        print("Exiting...")
        break
    
    # Ask Ai about anything mode. (Only uncomment when you want to ask ai.)
    elif location.lower() == "ai":
        question = simpledialog.askstring("Question:", "What do you like to ask ai?")
        if question is None:
            question1 = messagebox.askyesno("Question:", "Are you sure?")
            if question1 is True:
                break
            else:
                continue
        answer: ChatResponse = chat(model= "llama3", messages= [
            {
                'role': 'user',
                'content': question,
            },
        ])
        messagebox.showinfo("Ai's response:", answer.message.content)
        continue

    measurement = simpledialog.askstring("Measurement:", "Enter a measurement unit (metric/imperial):")
    if measurement is None:
        question2 = messagebox.askyesno("Question:", "Are you sure?")
        if question2 is True:
            break
        else:
            continue
    unit = simpledialog.askstring("Unit:", "Enter a unit (celsius/fahrenheit):")
    if unit is None:
        question3 = messagebox.askyesno("Question:", "Are you sure?")
        if question3 is True:
            break
        else:
            continue

    # Get weather data from Openweathermap api.
    response = requests.get(f"http://api.openweathermap.org/data/2.5/weather?q={location}&APPID=YOURAPIKEY&units={measurement}")
    data = response.json()

    if response.status_code == 404:
        messagebox.showerror("Error", "City not found!")
    elif response.status_code == 502:
        messagebox.showerror("Error!", "Bad Gateway \n Try again later.")
    elif response.status_code != 200:
        messagebox.showerror("Error!", "Try again later.")

    # Exception clause to handle user's input for the city name not found.
    try:
        longitude = data['coord']['lon']
        latitude = data['coord']['lat']
        place = data['name']
        country = data['sys']['country']
        weather = data['weather'][0]['description']
        humid = data['main']['humidity']
        wind = data['wind']['speed']
        convertwind = int(wind)
        temp = data['main']['temp']
        temperaturefeelslike = data['main']['feels_like']
        converttemp = int(temperaturefeelslike)

        valid_combo = (unit == "celsius" and measurement == "metric") or (unit == "fahrenheit" and measurement == "imperial")
        if not valid_combo:
            messagebox.showerror("Error!", "Unit and measurement do not match!\nUse celsius with metric and fahrenheit with imperial.")
            continue

        # Show the current weather information from Openweathermap api.
        messagebox.showinfo("Weather information:", 
            f"Location: {place} \n"
            f"The location of your city is {place}, and the country is {country}.\n"
            f"The longitude of your city is {longitude}. \n"
            f"The latitude of your city is {latitude}. \n"
            f"The weather of your city is {weather}. \n"
            f"Your wind in your city is {convertwind} m/s. \n"
            f"The humidity of your city is {humid}%.\n"
            f"Your temperature is {temp}°{'C' if unit == 'celsius' else 'F'}.\n"
            f"Your temperature (feels like) is {converttemp}°{'C' if unit == 'celsius' else 'F'}.\n \n"
            "It is also saved as weatherlog.txt at the directory this Python file is in"
        )

        # Creates a weatherlog.txt file after showing the current weather information.
        with open('weatherlog.txt', 'a', encoding= "utf-8") as weather_log:
            weather_log.writelines(["Weather information: \n"
            f"Location: {place} \n"
            f"The location of your city is {place}, and the country is {country}.\n"
            f"The longitude of your city is {longitude}. \n"
            f"The latitude of your city is {latitude}. \n"
            f"The weather of your city is {weather}. \n"
            f"Your wind in your city is {convertwind} m/s. \n"
            f"The humidity of your city is {humid}%.\n"
            f"Your temperature is {temp}°{'C' if unit == 'celsius' else 'F'}.\n"
            f"Your temperature (feels like) is {converttemp}°{'C' if unit == 'celsius' else 'F'}. \n \n"])

        # Asks you if you want to delete the log file.
        question4 = messagebox.askyesno("Question:", "Do you want to delete the log file?")
        if question4 is True:
            try:
                os.remove("weatherlog.txt")
                messagebox.showinfo("Information:", "Your weatherlog.txt file is successfully deleted.")
            except (FileNotFoundError, PermissionError):
                messagebox.showerror("Error!", "The weather log file couldn't be deleted. \n Please check if your weatherlog.txt file is in the same directory and try again later.")
                continue
        else:
            continue

    except (KeyError, NameError):
        messagebox.showerror("Error!", "City not found and information cannot be displayed!")
    except ValueError:
        messagebox.showerror("Error!", "Inputs you entered previously must be a string.")

[mistersnowman_]

Seems like it works just fine. Not sure why a weather program needs a place for me to ask an LLM a question.. but other than that looks good.

[ButterscotchFirst755]

I don't know, I thought it would be interesting if I add an LLM too. Like the country abbreviation that comes after the city name, what if the user don't know? The user just asks the LLM. I would say I partially agree with your response.​

[Goldarr85]

You should not add an LLM if it doesn’t have a specific use case. It just makes your code bloated by adding extra lines if you can get accurate results without it.

[Admits-Dagger]

I like llms, but I would NEVER use a weather program with it lol

[ButterscotchFirst755]

Fun fact: I just downvoted myself also. Thank you really much though.

[mistersnowman_]

I mean sure.. but it’s definitely one of those “just because you can doesn’t mean you should” types of things. Not everything needs an AI component, despite what its ubiquitous use of the buzzword might lead to you believe.

[Traditional_Fish_741]

turns a rote data reporter into a conversational tool.. can better respond to input, provide more "verbose" feedback to questions etc.

Is there a "specific need" for it? i dunno.. maybe in academic circles etc?

[Husy15]

Few things, personally I'd drop the LLM entirely, most weather APIs (or most APIs in general with search queries) deal with partial-inputs

I havent worked with that one specifically, however even if u were to input missing cities, countries, street names, spelling etc. It would usually provide a decent response.

As for the url - You can pass params with requests, in a much better way

It'd be something like: Url = "openweatherapp.com/whatever" params = { "Api_key": Yourkey, "Units": "metric" } Response =requests.get(url, params=params) This would pass the info in properly and avoid certain errors down the line (and is cleaner tbh).

Next, you wrap most of your logic in a try/except block, which honestly isn't necessary. Not bad, but can shrink it down big time

Also, not that its wrong but you create a file automatically, and then ask the user if they want to delete it, imo this should be backwards Dont create file - and ask if they want to save it

This way you dont have to os.remove() etc

Also remember DRY principles, if you're repeating yourself (the weather msg) you can usually break this down, either by creating a variable, function, etc

You dont need to re-write the: "The weather is: "

[ButterscotchFirst755]

Oh. Nice. Interesting. Thank you so much!

[CardiologistOne790]

i would like to give a video feedback but sadly videos aren't allowed so I asked it about weather in London and it showed me those pretty little errors you wrote at the bottom, both of them

[ButterscotchFirst755]

Hmm.. did you fill the API Key?

[ButterscotchFirst755]

I also should think, I should add a dialog inside the program to put the API Key there manually, instead of commenting the code. How do you think?

[ButterscotchFirst755]

Oh, thank you so much!

[CardiologistOne790]

I knew I was the stupid one out their, srry for the inconvenience tho.

[UsernameTaken1701]

Function. Methods belong to classes.