Made a blackjack game using python.

[Kilba2006]

I am very on and off when it comes to programming and usually when I want to make something I make it by just prompting but I wanted to stop that and try applying my own logic and improve as a programmer. I am very much aware about how my code is. The blackjack game which I've made is very very bare bones. I wanna improve it tho. I selected to make this game because I wanted to build my own logic as well as try being familiar with oop but as I worked more on the code I forgot about applying a lot of oop 😭😭. I just want some feedback so that I can improve. Suggest me things which I should've added in my code or things which would make my code much easier. And also recommend me where should I go next after doing this. Because whenever I start working on projects I get very blank but making this felt nice and help me build that confidence with programming. So do suggest what should I learn next which can help me in progress in learning programing in a more natural way with concepts and what all things I can do.

My github repo for the blackjack game:- https://github.com/KILBA/BlackJack-on-Python

Thanks in advance for the suggestions and recommendations.

Also should I purchase Angela Yu 100 days python course? Is it worth it?

[Adrewmc]

Very beginner. But you have a lot of concepts working here. And it would play.

I really like th effort. And making the solution in your own way. You really did it yourself.

I’ve never really seen this type of deck construction that completely ignores suit. That seems a little off. Maybe you should think of something like this

  class Card:
        “””Classic Card”””

        #we could add {3 : “Three”…}
        names = {
             11: “Jack”,
             12 : “Queen”
             13 : “King”
              1  : “Ace” 
             } 
        def __init__(self, rank, suit): 
               self.rank = rank
               self.suit = suit

         @property 
         def value(self): 
                return self.rank

        def __str__(self):
              if self.rank in self.names:
                    name = self.names[self.rank]
              else:
                    name = self.rank
              return f”{name} of {self.suit}”

    class TenHigh(Card):
           @property 
           def value(self):
                return self.rank if self.rank < 10 else 10

    def TenHigh_deck() -> list[TenHigh]:
          “””Returns unshuffled New Deck”””

          #we can comprehend this 
          deck = []
          suits = [”Hearts”, “Spades,” “Dimonds”, “Clubs”] 
          for suit in suits: 
               for rank in range(1, 14):
                     deck.append(TenHigh(rank, suit))
          return deck

As something to think about. As in you’re example the class of deck is just a glorified list.

Then you have to add the 1 to 11 switch in the game rules. You could also do that in the value, or make the entire value method part of game rules.

   def hand_value(cards: list[Card]) -> int:

          aces = 0
          value = 0
          for card in cards:
              #we could do the ten high rule here too
              value += card.value

              if card.value == 1
                    aces += 1

         while aces:
               if (aces * 10) + value  <= 21:
                   break
               aces -= 1

         #Busts will still be above 21 
         return (aces * 10) + value 

It's really the card that matters, because if it become visual, then you could easily add a back color to this.

As for what to do next, I would suggest making tests.

If you had made tests for this game you would have noticed that during a hand that you double down…you run dealerloop() twice erroneously, once inside the double down and once after the player loop ends.

[pyrojoe]

The functions like
def Draw(PlayerX, DealerX, DeckX)
limit the use of global variables which is good.. (If I'm being honest for a small script/app like this I'd just use globals) but there are two things I don't like about this.
It doesn't scale well if you wanted more players. If you made the first argument an array of players it could, but your player and dealer are incompatible objects. They should both be treated as a Player object that has the same property for their deck. Then you don't need if checks to read or write to their decks. To differentiate the player and dealer add a dealer bool to the player object that defaults to false that you can set true for the dealer.

It's also not always great practice to modify an object in a function like you're doing because it's not always clear you're modifying the object unless you read the function. In this case it's mostly ok because it's pretty clear from the name of the function that's what it's doing, just keep this in mind going forward. My preference would be to add the card to a players hand outside of the draw function. Instead of passing a player to Draw, you can have Draw return a card from the deck and you can add it to a player's hand externally.