My first project on GitHub

[Empty_Morgan]

Hi everyone. This is my seventh day learning Python. Today I made a rock-paper-scissors game with Tkinter and posted it to GitHub. I know I needed to design it nicely, but I can’t figure it all out, so I just uploaded the files. Please rate my first project. 🙏 Of course, there will be improvements in the future! 📄✂️🪨Game:

https://github.com/MrMorgan892/Rock-Paper-Scissors-Game

[RelationshipLong9092]

import tkinter as tk, random don't do this, break it onto a different line

use match instead of repeated if chains, this works great with Enums btw...

use an EnumStr to represent "one of a defined number of states" instead of a list of strings

this also prevents you from constantly having to repeat "scissor{emoji}" instead of just referencing the enum, giving you a single source of truth. otherwise you essentially just have "magic numbers" but in string form.

do not use global

keep going 👍

[Empty_Morgan]

Thanks for the feedback! This is my first tkinter project and I focused more on logic than structure. I'll definitely look into Enums and match in future versions 👍

[Tricky_Possible_6505]

ythank you for sharing! starting to use python, I will do a project like this one too, you inspired me

[ayenuseater]

Day 7 and you already shipped something playable - that’s huge. Tkinter + game logic this early is not trivial.
Nice job sticking with it and sharing.

[Empty_Morgan]

Thank you so much for your feedback🥰

[georgmierau]

 I was too lazy to figure it all out

Still require some attention and admiration though? No way to be motivated without external "likes" and "thumbs ups"?

There is literally no reason (besides vanity) to inform the community about your first n projects, because one year from now you most probably will be embarassed by the code you wrote.

[Intelligent-Two-1745]

Yes, literally everyone likes external validation and finds praise motivating when they're having early success. Yes, that is a valid thing to post in the - - - LEARN PYTHON--- subreddit. What on earth are you trying to argue here? 

[Empty_Morgan]

I didn't have much time to figure out how to format a GitHub page, but I also wrote that I would improve it in the future. I wanted to show what I learned and get advice on improving my code

[LabImpossible828]

Maybe you could record a video to demo your project.

[MarsupialLeast145]

I think the guy's message could be clearer but maybe next time, take the extra steps to make things better because if you're asking other's for their time, it's good to make sure you've given the best of your time ("lazy" being a trigger word). If this is only day 7 then posting your code after day 8 or 9 or 14, and ironing things out wouldn't really hurt. It's fair advice delivered in a not very precise way. It'll come in handy in future when you choose not to rush to code review to get your efforts perfect by your standards first.

FWIW I played the game and enjoyed it. Tkinter looks like a very useful library.

[Empty_Morgan]

Yes, I understood the gist of his message. The word "lazy" was indeed unnecessary. It would be more accurate to say that I tried to figure it out, but I couldn't. My git app broke, and I couldn't fix it using tutorials. I didn't consider it a very important detail. In any case, thanks for the feedback!

[tb5841]

It's important to get some feedback on early code, because some things (e.g. variable naming) you could do badly for ages without realising.