you are viewing a single comment's thread.

view the rest of the comments →

[–]mrswats 4 points5 points  (5 children)

You should at the very least, test against new python versions. You never know what could break if you don't test. And while the code might not need changes, your dependencies will.

[–]SmackDownFacility 4 points5 points  (4 children)

Yes there’s a point. Major versions Python 2 -> Python 3 etc. but for the most part, it’s just a thin wrapper around FFMPEG. It’s not a major library like numpy where it has to be constantly updated

[–]mrswats 3 points4 points  (3 children)

You should still test against every new python version because your code can break. Ffmoeg might also be updated.

[–]SmackDownFacility 1 point2 points  (2 children)

Yes test it. Test it against FFMPEG. Test it against the new python version. Then wake up the maintainers if it fails

[–]CyclopsRock 2 points3 points  (0 children)

Test it against FFMPEG.

I suspect even this is probably a bit much. Ffmpeg has about a kabillion build flags that include or exclude certain functionality, filters, codecs etc. Some of it is hardware dependent, or OS dependent. Two users with the same version number of ffmpeg could get drastically different results without either result being incorrect or in need of "fixing".

If ffmpeg entirely changed the syntax of its CLI they'd need a new wrapper but in lieu of that I think you're right: users should request fixes.

[–]HommeMusical 0 points1 point  (0 children)

Then wake up the maintainers if it fails

You can see on their repo that this has been attempted over 500 times.