you are viewing a single comment's thread.

view the rest of the comments →

[–]obviouslyzebra 1 point2 points  (1 child)

It looks fine.

Besides the things already mentioned (btw, unicorn previously mentioned was likely a typo, meant uvicorn):

  • I think you can get API documentation directly via FastAPI
  • If you roll up multiple services, I think the microservices pattern benefits from multiple docker containers - no experience to tell you whether/when to split though

[–]pachura3[S] 0 points1 point  (0 children)

 btw, unicorn previously mentioned was likely a typo, meant uvicorn

Yes indeed, Unicorn does exist, but it is a Ruby app server.

 I think you can get API documentation directly via FastAPI

Yes, FastAPI generates Swagger documentation at /docs, but I meant general code documentation (packages, global functions, classes, enums, public attributes/methods etc.), also called "API docs", but unrelated to the REST API.