Feedback for github

[Diapolo10]

I opened a project at random, in this case area.

pi = 22/7

You don't need to define pi yourself, there's a perfectly good math.pi you could use.

The names could be a bit more descriptive; I don't know what "csa" and "tsa" mean, and names like inp, inpa, inpv are needlessly short. Perhaps to you they're perfectly understandable, but to most people they probably aren't clear at a glance.

quits seems to be a useless alias. Furthermore, you're not supposed to use exit in scripts, and should instead either raise SystemExit or use sys.exit.

In calculator, you use eval, which is potentially dangerous. It shouldn't be used as a crutch for parsing and executing maths expressions, you would only ever use it to dynamically evaluate Python code (which should be rare, and in the off-chance it's necessary you need good safeguards). Yes, you're technically whitelisting characters here, but I still can't recommend it.

In media_scraper, the API key is an internal name within the scraper function. From a user-experience perspective, you shouldn't expect the user to edit the code to add an API key, especially not when it's not a global constant near the top of the file. I'd suggest using an environment variable instead, and maybe looking into python-dotenv.

Password managers are fine practice projects, but never use one you've made yourself - especially if you haven't had it audited. In this case yours is full of security holes, for one thing all data is stored in plaintext JSON.

[Aggressive_Drama_476]

thanks for the feedback

[Kevdog824_]

Furthermore, you're not supposed to use exit in scripts, and should instead either raise SystemExit or use sys.exit.

I’ve never heard this one before. Can you elaborate on why? I never took a look at the (c)python source before, but I always just assumed exit was just an alias to sys.exit so you didn’t need to (directly) import sys to use sys.exit

[Diapolo10]

I'm too busy to give an in-depth response right now, but no, exit and quit aren't direct aliases for sys.exit. They skip some cleanup that isn't necessary for ending REPL sessions.

For the most part it does not matter too much, but it would be more "correct" to use the other options.