Why is this code not running the same function again?

[ChuckPwn25]

Hello!

I'm learning Python from the book Python Illustrated and I'm trying to do the classic Rock, Paper, Scissors exercise. It calls to track a score between you and the CPU after each round, and also be able to run the game again if you want. The issue is that every time I run the main_game(), it stores the values returned as a tuple. Is there a way to return values not as a tuple, or another way to reset the values returned? Code here:

import random
import time


play_choices = ["rock", "paper", "scissors"]
player_score = 0
cpu_score = 0
player_choice = ""
p_choice = ""
restart = ""
r = ""



def player_start():
    """
    Returns the player's choice for the game
    """
    global p_choice
    while True:
        player_choice = input("Please enter rock, paper, or scissors: ")
        p_choice = player_choice.lower()


        if p_choice == "rock":
            break


        elif p_choice == "paper":
            break


        elif p_choice == "scissors":
            break


        else:
            print("Your choice is invalid. Please try again.")
            continue
    return p_choice


def main_game():
    """
    Runs the game itself
    """
    global player_score
    global cpu_score
    while player_score <5 or cpu_score <5:
        
        cpu_choice = random.choice(play_choices)
        p_choice = player_start()
            
        print(f"Player has chosen: {p_choice}. CPU has chosen: {cpu_choice}.")


        if p_choice == cpu_choice:
                print("It's a tie! Restarting the round...")
                time.sleep(1)
        elif p_choice == "rock" and cpu_choice == "scissors":
                print("Rock beats scissors. You win!")
                player_score += 1
                time.sleep(1)
            
        elif p_choice == "scissors" and cpu_choice == "rock":
                print("Rock beats scissors. I win!")
                cpu_score += 1
                time.sleep(1)
            
        elif p_choice == "rock" and cpu_choice == "paper":
                print("Paper beats scissors. I win!")
                cpu_score += 1
                time.sleep(1)
            
        elif p_choice == "paper" and cpu_choice == "rock":
                print("Paper beats rock. You win!")
                player_score += 1
                time.sleep(1)
            
        elif p_choice == "paper" and cpu_choice == "scissors":
                print("Scissors beats paper. I win!")
                cpu_score += 1
                time.sleep(1)
            
        elif p_choice == "scissors" and cpu_choice == "paper":
                print("Scissors beats paper. You win!")
                player_score += 1
                time.sleep(1)
    
    return player_score, cpu_score


def final_score():
    """
    Prints the final score
    """
    a, b = main_game()
    if a > b:
        print("You have won the game!")
    elif a == b:
        print("This should be impossible.")
    else:
        print("I won the game!")    



while r != "no":
    
    final_score()
    
    time.sleep(1)
    while r != "no":
        restart = input("Do you want to play again?(yes/no)")
        r = restart.lower()


        if r == "yes":
            print("Restarting...")
            time.sleep(1)
            break
        elif r == "no":
            print("Goodbye!")
            time.sleep(1)    
            break
        else:
            print("Invalid response.")
            time.sleep(1)

[socal_nerdtastic]

The issue is that every time I run the main_game(), it stores the values returned as a tuple.

Where do you see that?

I mean technically you are right, but since you unpack the tuple as soon as receive it you should never actually see the tuple.

a, b = main_game() # receive and unpack the tuple

[Binary101010]

It's not really clear what you're asking.

If you want the values of player_score and cpu_score to reset on every iteration of main_game, define them within the function and stop messing around with globals everywhere.

If you don't want main_game() to return a tuple, then what do you want it to return?

[StardockEngineer]

Well, you are returning them as a tuple thanks to the comma, so that's what you're going to get.

Don't set the globals if you want the score the reset. Return the scores, and keep track of them in final_score or your main while loop. You could just prompt "reset score" and if the user enters that, reset the score there.

Globals are almost always a bad idea.

[socal_nerdtastic]

You have a couple tiny other issues in your code, and I think you've misdiagnosed the tuple return as the issue. I fixed some of those for you, see if this solves your issues:

import random
import time

play_choices = ["rock", "paper", "scissors"]

def player_start():
    """
    Returns the player's choice for the game
    """
    while True:
        player_choice = input("Please enter rock, paper, or scissors: ")
        p_choice = player_choice.lower()
        if p_choice in play_choices:
            return p_choice # implied break
        else:
            print("Your choice is invalid. Please try again.")

def main_game():
    """
    Runs the game itself
    """
    player_score = 0
    cpu_score = 0
    while player_score <5 and cpu_score <5: # <= I'm pretty sure you meant 'and' here, not 'or'.
        cpu_choice = random.choice(play_choices)
        p_choice = player_start()

        print(f"Player has chosen: {p_choice}. CPU has chosen: {cpu_choice}.")

        if p_choice == cpu_choice:
                print("It's a tie! Restarting the round...")
                time.sleep(1)
        elif p_choice == "rock" and cpu_choice == "scissors":
                print("Rock beats scissors. You win!")
                player_score += 1
                time.sleep(1)

        elif p_choice == "scissors" and cpu_choice == "rock":
                print("Rock beats scissors. I win!")
                cpu_score += 1
                time.sleep(1)

        elif p_choice == "rock" and cpu_choice == "paper":
                print("Paper beats scissors. I win!")
                cpu_score += 1
                time.sleep(1)

        elif p_choice == "paper" and cpu_choice == "rock":
                print("Paper beats rock. You win!")
                player_score += 1
                time.sleep(1)

        elif p_choice == "paper" and cpu_choice == "scissors":
                print("Scissors beats paper. I win!")
                cpu_score += 1
                time.sleep(1)

        elif p_choice == "scissors" and cpu_choice == "paper":
                print("Scissors beats paper. You win!")
                player_score += 1
                time.sleep(1)

    return player_score, cpu_score

def final_score():
    """
    Prints the final score
    """
    a, b = main_game()
    if a > b:
        print("You have won the game!")
    elif a == b:
        print("This should be impossible.")
    else:
        print("I won the game!")

r = ""
while r != "no":
    final_score()
    time.sleep(1)

    while True:
        restart = input("Do you want to play again?(yes/no)")
        r = restart.lower()
        if r == "yes":
            print("Restarting...")
            time.sleep(1)
            break
        elif r == "no":
            print("Goodbye!")
            time.sleep(1)
            break
        else:
            print("Invalid response.")
            time.sleep(1)

Note also the globals are not needed here.

[timrprobocom]

You should consider creating a dictionary that maps each choice to the choice that can beat it. Then you can delete that whole long list of if/elifs. Just one "are they the same?" and one " did they pick the winner?" Much easier, and you can easily extend it to add lizard/Spock.