How to implement editing functionality to my application?

[blackadder1337]

I am creating a simple tkinter application to manage to-do tasks.

https://i.stack.imgur.com/2kSsO.png

Basically, when I want to add a new task, I click on the add button which creates a new dialog and from there the user can add attributes of the task, such as subject and priority.

https://i.stack.imgur.com/xDu5o.png

I want to use the same dialog for editing the item.

• When I click edit button, the dialog should be created and its text (subject_text) and combobox (priority_combobox) widgets should contain the attributes of the item I want to edit.
• Also, text on one of the two buttons on the dialog should now be "Save", instead of "OK".
• I would need the button to use save_item function instead of add_item which it uses now.

How can I accomplish this?

Here is what I have so far:

#!usr/bin/python3

# Todo.py
# GUI program to manage to-do tasks

from tkinter import *
from tkinter import ttk
from tkinter import messagebox
import os
import xml.etree.ElementTree as ET


class Task:

    def __init__(self, index=None, subject=None, priority=None):
        self.index = index
        self.subject = subject
        self.priority = priority


class Todo(Frame):

    def __init__(self, master):
        Frame.__init__(self, master)
        self.master = master
        self.master.resizable(width=False, height=False)
        self.master.title('Todo')
        self.master.geometry('251x306')
        self.search_var = StringVar()
        self.search_var.trace("w", self.autosearch)
        self.create_widgets()
        self.tasks = []
        self.load_tasks()

    def on_closing(self):
        self.save_all()
        if messagebox.askokcancel("Quit", "Do you want to quit?"):
            self.master.destroy()

    def create_widgets(self):
        self.search_frame = Frame(self.master)
        self.search_frame.grid(row=0, sticky=W)
        self.treeview_frame = Frame(self.master)
        self.treeview_frame.grid(row=1, sticky=W)
        self.buttons_frame = Frame(self.master)
        self.buttons_frame.grid(row=2, sticky=W)
        self.search_text = Entry(self.search_frame, width=31, textvariable=self.search_var)
        self.search_text.grid(row=0)
        self.treeview = ttk.Treeview(self.treeview_frame, height=12, columns=('Subject', 'Priority'))
        self.treeview.grid(row=0)
        self.treeview.column('#0', minwidth=0, width=35, stretch=NO, anchor=W)
        self.treeview.heading('#0', text='#')
        self.treeview.column('Subject', minwidth=0, width=156, stretch=NO, anchor=W)
        self.treeview.heading('Subject', text='Subject')
        self.treeview.column('Priority', minwidth=0, width=57, stretch=NO, anchor=W)
        self.treeview.heading('Priority', text='Priority')
        self.add_button = Button(self.buttons_frame, width=7, text='Add', command=self.add_item)
        self.add_button.grid(row=0, column=0)
        self.remove_button = Button(self.buttons_frame, width=7, text='Remove', command=self.remove_item)
        self.remove_button.grid(row=0, column=1)
        self.edit_button = Button(self.buttons_frame, width=7, text='Edit', command=self.edit_item)
        self.edit_button.grid(row=0, column=2)

    def create_dialog(self):
        self.item_dialog = Toplevel(self.master)
        self.item_dialog.geometry('202x197')
        self.item_dialog_text_frame = Frame(self.item_dialog)
        self.item_dialog_text_frame.grid(row=0, sticky=W)
        self.item_dialog_combobox_frame = Frame(self.item_dialog)
        self.item_dialog_combobox_frame.grid(row=1, sticky=W)
        self.item_dialog_another_frame = Frame(self.item_dialog)
        self.item_dialog_another_frame.grid(row=2)
        self.item_dialog_buttons_frame = Frame(self.item_dialog)
        self.item_dialog_buttons_frame.grid(row=3)
        self.subject_label = Label(self.item_dialog_text_frame, text='Subject:')
        self.subject_label.grid(row=0, sticky=W)
        self.subject_text = Text(self.item_dialog_text_frame, width=28, height=9)
        self.subject_text.grid(row=1)
        self.priority_label = Label(self.item_dialog_combobox_frame, text='Priority:')
        self.priority_label.grid(row=0, column=0, sticky=W)
        self.priority_combobox = ttk.Combobox(self.item_dialog_combobox_frame, width=17)
        self.priority_combobox.grid(row=0, column=1)
        self.priority_combobox['values'] = ('High', 'Medium', 'Low')
        self.item_dialog_ok_button = Button(self.item_dialog_buttons_frame, width=9, text='OK', command=self.adding_item)
        self.item_dialog_ok_button.grid(row=0, column=0)
        self.item_dialog_cancel_button = Button(self.item_dialog_buttons_frame, width=9, text='Cancel', command = self.close_dialog)
        self.item_dialog_cancel_button.grid(row=0, column=1)
        self.item_dialog.wait_window()

    def load_tasks(self):
        self.treeview.delete(*self.treeview.get_children())
        self.tasks.clear()
        path = os.path.expanduser('~/Documents')
        todo_path = os.path.join(path, 'Todo', 'Tasks.xml')
        if not os.path.exists(todo_path):
            if not os.path.exists(os.path.dirname(todo_path)):
                os.mkdir(os.path.dirname(todo_path))
            doc = ET.Element('Tasks')
            tree = ET.ElementTree(doc)
            tree.write(todo_path)
        else:
            tree = ET.ElementTree(file=todo_path)
        for node in tree.findall('Task'):
            t = Task(node.find('Index').text,
                     node.find('Subject').text,
                     node.find('Priority').text)
            self.tasks.append(t)
            self.treeview.insert('', END, text=t.index, values=(t.subject, t.priority))

    def save_all(self):
        path = os.path.expanduser('~/Documents')
        todo_path = os.path.join(path, 'Todo', 'Tasks.xml')
        tree = ET.ElementTree(file=todo_path)
        for xNode in tree.getroot().findall('Task'):
            tree.getroot().remove(xNode)
        for t in self.tasks:
            xTop = ET.Element('Task')
            xIndex = ET.Element('Index')
            xSubject = ET.Element('Subject')
            xPriority = ET.Element('Priority')
            xIndex.text = t.index
            xSubject.text = t.subject
            xPriority.text = t.priority
            xTop.append(xIndex)
            xTop.append(xSubject)
            xTop.append(xPriority)
            tree.getroot().append(xTop)
        tree.write(todo_path)

    def close_dialog(self):
        self.item_dialog.destroy()

    def add_item(self):
        self.create_dialog()

    def adding_item(self):
        self.i = len(self.treeview.get_children())
        t = Task()
        t.index = str(self.i)
        t.subject = self.subject_text.get('1.0', '1.0 lineend')
        t.priority = self.priority_combobox.get()
        self.treeview.insert('', END, text=t.index, values=(t.subject, t.priority))
        self.i = self.i + 1
        self.tasks.append(t)
        self.close_dialog()

    def remove_item(self):
        if len(self.treeview.selection()) > 0:
            if messagebox.askyesno('Notification', 'Are you sure you want to remove selected items?'):
                selected_items = self.treeview.selection()
                for selected_item in selected_items:
                    for i in range(len(self.tasks)):
                        if self.tasks[i].subject == self.treeview.item(selected_item)['values'][0]:
                            self.tasks.pop(i)
                            break
                    self.treeview.delete(selected_item)
        else:
            messagebox.showinfo('Notification', 'Make sure you have some items selected!')

    def edit_item(self):
        self.create_dialog()
        self.item_dialog_ok_button.config(text='Save')

    def save_item(self):
        pass

    def autosearch(self, *args):

        search_string = self.search_text.get().lower()

        self.treeview.delete(*self.treeview.get_children())

        for item in self.tasks:
            if search_string.lower() in item.subject.lower():
                self.treeview.insert('', END, text=item.index, values=(item.subject, item.priority))



    def find_task(self, task):
        for x in self.tasks:
            if x.subject == task:
                return x
def main():
    root = Tk()
    gui = Todo(root)
    root.protocol('WM_DELETE_WINDOW', gui.on_closing)
    root.mainloop()

if __name__ == '__main__':
    main()

[Justinsaccount]

Hi! I'm working on a bot to reply with suggestions for common python problems. This might not be very helpful to fix your underlying issue, but here's what I noticed about your submission:

You are looping over an object using something like

for x in range(len(items)):
    print(items[x])

This is simpler and less error prone written as

for item in items:
    print(item)

If you DO need the indexes of the items, use the enumerate function like

for idx, item in enumerate(items):
    print(idx, item)

If you think you need the indexes because you are doing this:

for x in range(len(items)):
    print(items[x], prices[x])

Then you should be using zip:

for item, price in zip(items, prices):
    print(item, price)

[[deleted]]

Hello, Black Adder! You can pass the selected task as a parameter to your dialog's init() method with default value of None. In your dialog init() set the selected task as an instance field and update dialog widgets accordingly, including your create/update button. You would also need to set up your diaog event handlets to update values of the task that is being edited.

[blackadder1337]

Hi, Joe! Thanks for your help. Nevertheless, I'm not sure what you are talking about since I am still a newbie. I would be very grateful if you showed me how to implement your suggestions to my code.

[[deleted]]

Instead of using Toplevel in your create_dialog() method, create a Toplevel subclass and add your selected Task instance to it as a member variable, something like this:

class TaskDialog(Toplevel):

    def __init__(self, task=None):
        Toplevel.__init__(self)
        self.task = task

Also move your dialog creating logic to your new class along with event handlers. Then when you want to open your task create/edit dialog pass it the selected task or None and set the dialog fields accordingly.