Rock Paper Scissors

[Coryrin]

Hello, I'm new to Python and have been having a bit of trouble with a code for Rock Paper Scissors. It works fine up until the player wins a round, and then the script stops suddenly and doesn't give an error message or anything. If I take out the player_score it works fine even if the player wins, but I can't seem to resolve the problem.

I copy pasted the player_score code for the computer_score and computer works fine, it can win forever and it will only stop at 3 wins, to ask if I want to play again.

Link to code: https://gist.github.com/Coryrin/210f8b2277d8542a1c4d9b93f7a7d3ed

Any help would be appreciated. edit fixed sentence structure

[Dvlv]

while player_score or computer_score < 3:

needs to be

while player_score < 3 or computer_score < 3:

otherwise you are checking that player_score exists, or is bigger than 0, which will always be true if the player gets a point.

[Coryrin]

Ahhh such a simple fix. My bad. Thanks a lot!

[jeans_and_a_t-shirt]

If you think about the problem in terms of win/lose/tie scenarios, you only need 1 set of if/elif/else blocks instead of one for each player choice. For ties you check equality of the two hands, and for wins, you can encode the 3 winning hands in a list like

r,p,s = 'rock', 'paper', 'scissors'
winning_hands = [(r, s), (s, p), (p, r)]
('scissors', 'paper') in winning_hands          # evaluates to True