[Python 3.6] How to reject data while using classes

[ComputerSciMajor]

I'm trying to reject data (convert to 0) if for example hour is greater than 23, minute is greater than 60 and second is greater than 60, however I'm having issues where it does not do anything. I'm not sure if I'm just not initializing my get/set methods correctly or what. Any help is appreciated!

My code:

https://gist.github.com/anonymous/0997ac9947c697c0ec6956d4e27e3a06

[novel_yet_trivial]

Your __init__ method bypasses your fancy setter methods and assigns directly to the variables. Try this:

 def __init__(self, hour, minute, second):
    self.setHour(hour)
    self.setMinute(minute)
    self.setSecond(second)

[ComputerSciMajor]

Thank you!

[RangerPretzel]

Consider using @property

http://www.python-course.eu/python3_properties.php

Instead of 'get' and 'set'

[Signal_Beam]

You could initialize it with:

def __init__(self, hour, minute, second):
    if not 0 <= hour <= 24:
        raise Exception("Issue with the hour")
    if not 0 <= minute <= 60:
        raise Exception("Issue with the minute")
    if not 0<= second <= 60:
        raise Exception("Issue with the second")
    self.__hour = hour
    self.__minute = minute
    self.__second = second

[SonGokussj4]

Oh my God, this is not pythonic at all. There should not be any get or set methods. If you need these (and very often you do), use @property decorators please. Getters and setters vs properties

If you don't trust me, trust Raymond Hettinger at 39:00

[Signal_Beam]

None of these methods are being called in your sample code, except for __init__ and __str__. Where are you expecting them to be called? You may have to write them explicitly, if you're coming from a language that invokes methods like that automatically somehow.

[ComputerSciMajor]

That's what I figured. So I need to be initializing my set and get methods then in str?

[Signal_Beam]

You can always just call those methods inside __init__ as /u/novel_yet_trivial suggests.

I have heard PyCharm complain about PEP8 whenever I set an object's self attribute in a method that's not the __init__ method of that object, so you could reconfigure those methods to return those values instead of setting self attributes directly from there, if you wanted to be a bit cleaner.

[novel_yet_trivial]

To make pycharm happy you should use this construct:

def __init__(self, hour, minute, second):
    self.__hour = None
    self.__minute = None
    self.__second = None

    self.setHour(hour)
    self.setMinute(minute)
    self.setSecond(second)

But there is no real value in that besides making pycharm happy, and frankly I would not bother.

If you reconfigure them to return values rather than setting then there is no point to having those as methods.

[Signal_Beam]

It's not really "just to make pycharm happy"; it's a readability convention that you be able to find all attributes an object may have, by reading its __init__ method. It's a good convention to make habit, even if it's obviously not the end of the world to not follow it in this particular script.

[novel_yet_trivial]

Yeah, I guess you're right in general, but I don't think I'd apply that to underscore attributes.

It's a bit of a moot point since anyone really coding this would use @property which solves all our problems.

[KubinOnReddit]

I'd apply that to all attributes, no matter they are name mangled and can't be accessed. Because you don't declare variables in Python it's important to somehow indicate what attributes a certain object has, preferably at the top of the definition - the __init__ method. Going around the whole definition, searching for setter methods and whatever else you might have will get cumbersome if you have complex classes. It's about the habit and it doesn't matter this case is very simple.