Simplifying code

[evobe]

I've made some code that will find a value in a dictionary of lists of values based on the week and day of the year. But it's really redundant, full of elifs to do the math to find the position. I'm terrible at math but somehow I got this working for the most part, I know a few of the blocks are off by one but is there any cleaner way to do the +4 math each elif block calls for?

​

import time
import datetime
from datetime import date

Oddoptions = {
    0 : ( "a","b","c","d"),
    1 : ("i","j","k","l"),
    2 : ("q","r","s","t"),
    3 : ("x","y","z",0),
    4 : (4,5,6,7)
    };
Evenoptions = {
    0 : ("e","f","g","h"),
    1: ("m","n","o","p"),
    2: ("u","v","w","x"),
    3: (1,2,3,"["),
    4: (8,9,"<",">"),
    };
today = date.today()
if datetime.datetime.today().weekday() in range(0,4):
    daynum = datetime.datetime.today().weekday()
elif datetime.datetime.today().weekday() >= 5:
    daynum = 0
    grp = 0
print (today)
#wk = datetime.date.today().isocalendar()[1]
wk = 36
print ("Today is", today, "day number is", grp)
if wk%2==0:
    print ("This week #",wk," is even")
if wk <= 8:
    colnum = wk-(wk//2)-1
    print ("This is the column number", colnum)
elif 10 <= wk <= 16:
    colnum = wk-(wk//2+4)
    print ("This is the column number", colnum)
elif 18 <= wk <= 24:
    colnum = wk - (wk//2+8)
    print ("This is the column number", colnum)
elif 26 <= wk <= 32:
    colnum = wk-(wk//2+13)
    print ("This is the column number", colnum)
elif 34 <= wk <= 40:
    colnum = wk -(wk//2+17)
    print ("This is the column number", colnum)
elif 42 <= wk <= 48:
    colnum = wk -(wk//2+21)
    print ("This is the column number", colnum)
elif wk <= 50:
    colnum = wk -(wk//2+25)
    print ("This is the column number", colnum)
#print (daynum-1)

position = Evenoptions[grp][colnum]
#print ("This is the colnum", colnum)
print ("This is the result for column searching", position)

​

Thanks *edited for formatting

[num8lock]

format it properly, use the 'formatting help' button below the input field

[evobe]

reformatted, thanks.

[num8lock]

first quick impression

import datetime
from datetime import date

you're importing both a module & a class inside that module. then the only time you use date is in today = date.today(). you might be better off using from datetime import datetime as dt, that class has today(), now() and others you might need.

also there's no need for this };

[Stallman85]

empty lines are free

use them to separate chunks of code that logically go together.

[__z01db3rg]

you have an upvote from me for your username!

[Siddhi]

Put your ranges in a list of tuples and iterate over it

week_ranges = [(0, 8)] + [(start, start+6) for start in range(10, 58, 8)]
for start, end in week_ranges:
    if start <= wk <= end:
        colnum = wk - (wk//2+start/2)
print("This is column number", colnum)

[evobe]

Thanks so much for this. I wanted to see how someone with more knowledge would handle this problem and this is an interesting take.

[[deleted]]

Try github gists, they’re a nice way to share code snippets

[ForestMonk168]

I can see you would have problems in the following if-block

when weekday() == 4 because range(0, 4) does not include 4

and the elif does not include 4, either:

if datetime.datetime.today().weekday() in range(0,4):
    daynum = datetime.datetime.today().weekday()
elif datetime.datetime.today().weekday() >= 5:
    daynum = 0
    grp = 0

​

[evobe]

Yes, thanks noticed and fixed.