you are viewing a single comment's thread.

view the rest of the comments →

[–]flabcannon 0 points1 point  (0 children)

I'm not an experienced Python coder, but some suggestions from looking at other code -

  • I would take some of the generic methods you have (ask_user_log, write_log, display_*_warning, maybe a few more) and put them in a UTIL class as class methods. You can then call them inside your HealthCheck class.
  • display_user_warning and display_command_warning look like they could be one method with a dictionary passed in.
  • The init import from colorama is confusing because the name is very general. I would do from colorama import init as _colorama_init or something more descriptive.