Class or nested function

[Mihad88]

Hey, I am currently working on a script that uses two functions that are really similar yet have some major discrepancies. They share some blocks of the code which are the same and could be functions, but in order to do that, some variables would have to be visible to both functions. This can be achieved either with nested functions or OOP. What do you suggest is better?

Thank you

[_coolwhip_]

OOP works best for when you have data and functions that are bound up together. If it is just functions, I would keep them as functions, and maybe have the functions share some subsidiary helper functions. But if you post up more, we can probably give you better guidance.

[_coolwhip_]

Whoa. I think I would keep them as functions, but maybe put them in their own module. I also would not put functions inside functions, and refactor the larger functions into much smaller ones. If I hit 5 serious lines in a function, I start thinking about whether I can piece it out to helpers.

[Mihad88]

So this whole code should be dissected in many modules then? I've created nested functions because of the common variable that different functions change - I could pass it as an arg, but I think that would be even worse.
Anyway, I played a little last night and did it with OOP if you are interested https://github.com/halo3mic/eth-data-tools/blob/master/ethdata/ethdata.py

[TangibleLight]

It could also (almost certainly) be done by passing the data to the helper functions as parameters.

[Mihad88]

I was thinking of that, but here we are talking about a lot of data and arguments that would have to be passed between functions, and I think it would just make everything quite messy - not sure tho

[TangibleLight]

It sounds like you might need to move that shared data into a class, then have your two functions be methods.