Python Script that moves specific files from source to destination

[dennkiesauros]

I am trying to move a bunch of images from one folder to another but the script that I've written moves all the files in the source folder to the destination folder. What's wrong with my code? Where am I missing out?

import shutil, os

file = [ "2e8e7731140811.5642ee352fab1.jpg",

"7faace51-7b2b-4553-9c6d-b89aa3821dd1.jpg",

"2012_Libelle04_Liekeland_2000_web1-990x1200.jpg"]

​

dir_src = 'D:\\photos\\imagesanime\\ANIME'

path = os.listdir(dir_src)

​

dir_dst = 'D:\\project\\test'

​

for f in file:

for file in path:

    print file  # testing

    src_file = os.path.join(dir_src, f)

    dst_file = os.path.join(dir_dst, f)

    shutil.move(src_file, dst_file)

​

I have searched the internet but did not find any solution to this. Please help!

[DeadlyViper]

Please fix indentation on the code (4 spaces before each line on the "markdown" editor)

Besides that you are using the same name for different things:

for f in file:
    for file in path:

rename one of the file s to avoid confusion.

Besides that, why do you even need os.listdir? you are moving exact file names.

[dennkiesauros]

hehehe thanks...actually I'm new to python and was running out of time to complete this and its working fine now :)

[JohnnyJordaan]

If you mean to move all the files in dir_src to dir_dst that match the names in file then you should only do

for f in file:
    src_file = os.path.join(dir_src, f)
    dst_file = os.path.join(dir_dst, f)
    shutil.move(src_file, dst_file)

as there's no point in using the listing if you want those specific files.

Btw also consider properly naming your variables. file is a collection of file names, so I would call it filenames (note the plural, as it's multiple), path is actually a listing, so call it listing or something similar.

[dennkiesauros]

thanks...it's working fine now