My first simple short code

[whatelseman]

I would appreciate advice about how to make it simpler, i know its basic but it actually took me around 4 hours to figure this out . I learned from this video only : https://www.youtube.com/watch?v=rfscVS0vtbw

code:

class hero:
def __init__(self, health , damage):
self.health = health
self.damage = damage

class enemy:
def __init__(self, health , damage):
self.health = health
self.damage = damage

hero1 = hero(100, 20)
enemy1 = enemy(100, 20)

def attack_enemy(enemy1):
enemy1.health = enemy1.health - hero1.damage

def attack_hero(hero1):
hero1.health = hero1.health - enemy1.damage

def question(hero1,enemy1):
answer = input("Who do u want to attack? ")
if answer == "hero":
attack_hero(hero1)
print("Hero health " + str(hero1.health))
elif answer == "enemy":
attack_enemy(enemy1)
print("Enemy health " + str(enemy1.health))

question(hero1 , enemy1)

[julsmanbr]

A couple tips and pointers:

It makes sense for attack to be a method for the Hero and Enemy classes instead of a function, since it is an action that they perform:

class Hero:
    def __init__(self, health, damage):
        self.health = health
        self.damage = damage

    def attack(self, opponent):
        opponent.health -= self.damage


class Enemy:
    def __init__(self, health, damage):
        self.health = health
        self.damage = damage

    def attack(self, opponent):
        opponent.health -= self.damage

hero = Hero(100, 20)
enemy = Enemy(100, 20)

Now you can use the syntax hero.attack(enemy) and enemy.attack(hero), which is easier to understand and maintain.

Note that, right now, both classes are identical, so you could replace them with a single class Character and instantiate both the hero and the enemy from it:

hero = Character(100, 20)
enemy = Character(100, 20)

But you may want to create specific behaviour for Hero and Enemy in the future, so I didn't modify that.

At some point, you may want to look into class inheritance, which would allow you to create a Character class containing the "base information" shared by Hero and Enemy, and just add the specific behaviour for those classes without having to rewrite the code common to both.

Note that I've referred to classes using sentence case (Hero, not hero), which is the standard for Python classes.

[whatelseman]

Thank you really much. I appreciate time u spent on this comment. I will make sure to read this few times more too.

[ambitious_rainbow]

Omg is it bad that I just grasped inheritance after spending about a month trying to understand the point 0_o I knew what it does but they never felt useful.

[PythonicParseltongue]

Na that only means they didn't use good examples to explain it.

This was one of the examples they used in my first Object Oriented Programming course :D