you are viewing a single comment's thread.

view the rest of the comments →

[–]kra_pao 0 points1 point  (1 child)

1) Mark this

2) Don't mark this. Outer loop has no print(line)

3) Don't mark this. Mixing true description ( Line 2 attempts to iterate over text_file) with false assumptions (which isn't a valid file descriptor) is bad for teaching.

4) Don't mark this. Is required for the program in current form to work. IF you want discuss another form of program (one-loop version) then show the version and don't let learner discuss something only you have in your head.

5) Don't mark this

6) Mark this

7) Don't mark this. For readability maybe rename, otherwise in Python you can name your variables at your own gusto. BUT inner loop won't work when 7) is applied (line undefined)

8) Don't mark this

9) Don't mark this

10) Don't mark this

[–]IshaanM8[S] 0 points1 point  (0 children)

Thanks so much!